Avoid stream polyfill for GFF3/GTF parsing #4547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GMOD/gff-js#62
I extracted the non-streaming parts of the gff and gtf parsers into their own NPM packages that can be used in isolation, and called the packages gff-nostream and gtf-nostream
This reduces the need for node.js polyfills and the stream-browserify workaround
Potentially, even the streaming parts of @gmod/gff could use gff-nostream as a base package to avoid the code duplication, but right now, this would just remove @gmod/gff and @gmod/gtf entirely from the build in favor of the non-streaming new packages
note: the naming gff-nostream is a little awkward but was hard to come up with something clearly named to distinguish it from @gmod/gff
saves about 50kb ungzipped/15kb gzipped js