Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Modularize out a non-stream version of the package #62

Closed
cmdcolin opened this issue May 3, 2023 · 2 comments · Fixed by GMOD/jbrowse-components#4547
Closed

Comments

@cmdcolin
Copy link
Contributor

cmdcolin commented May 3, 2023

I think for some purposes, it is not necessary to use streams to parse the GFF, and it may be worth it to make a non-stream version. It complicates browserification, and even with the "browser":"stream-browserify" branch, it seems to cause issue (as seen by @garrettjstevens work on web streams as an alternative, trying to just remove this entirely)

I would say a non-stream version could be conceptually 'simpler' to reason about, though it could result in some code duplication if we maintain a non-stream and a stream version

@cmdcolin
Copy link
Contributor Author

cmdcolin commented May 3, 2023

also, tangent, but if the "browser":"stream-browserify" package.json field is causing significant issue, we could revert it potentially

@cmdcolin cmdcolin changed the title Modularize out a non-stream version of the package Proposal: Modularize out a non-stream version of the package May 3, 2023
@tuner
Copy link

tuner commented May 22, 2023

Oh, this would be awesome. I'm currently struggling with this package, as the stream-browserify workaround does not behave nicely on Vite.

Module "events" has been externalized for browser compatibility. Cannot access "events.EventEmitter" in client code. See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
@gmod_gff.js?v=53f624f2:16
Uncaught ReferenceError ReferenceError: global is not defined
    at ../../node_modules/readable-stream/lib/_stream_readable.js 
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants