Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave sessions in jbrowse-web IndexedDB database to make it easier to access old sessions #4074

Merged
merged 17 commits into from
Dec 7, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 22, 2023

users can run out of local storage limits with large sessions, and the system can also forget your recent sessions fairly easily

On desktop, we have autosave, this basically ports the same concept to web by using indexeddb which has much higher storage limits

Fixes #3575
Fixes #3392
Fixes #1445
Fixes #4690
Fixes #1384

standardizes on saving sessions by ID, which is a good indication of being the same exact session, instead of name, which is just the same by happenstance in most cases

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 22, 2023
@cmdcolin cmdcolin added enhancement New feature or request size medium not trivial and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 22, 2023
@cmdcolin cmdcolin force-pushed the idb branch 6 times, most recently from ae43cc2 to 21ab976 Compare November 29, 2024 17:11
@cmdcolin cmdcolin marked this pull request as ready for review November 29, 2024 17:13
@cmdcolin cmdcolin changed the title Store sessions in indexed db database Store sessions in IndexedDB database Nov 29, 2024
@cmdcolin cmdcolin changed the title Store sessions in IndexedDB database Store autosave sessions in IndexedDB database Nov 29, 2024
@cmdcolin cmdcolin force-pushed the idb branch 4 times, most recently from cfe56c2 to f063778 Compare November 30, 2024 03:43
@cmdcolin cmdcolin removed the size medium not trivial label Nov 30, 2024
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 4, 2024

some todo's from meeting with @garrettjstevens

  • add mouseover date/time
  • move menus to the session model
  • create concept of "favorites" on the recent sessions table. this would supplant the current concept of 'saved sessions'
  • try not to load all data using getAll...just get session name/createdAt for example, and maybe limit total number of sessions

@cmdcolin cmdcolin force-pushed the idb branch 5 times, most recently from a421371 to 3873edf Compare December 7, 2024 02:52
@cmdcolin cmdcolin merged commit 159a621 into main Dec 7, 2024
@cmdcolin cmdcolin deleted the idb branch December 7, 2024 03:58
@cmdcolin cmdcolin changed the title Store autosave sessions in IndexedDB database Autosave sessions in jbrowse-web IndexedDB database to make it easier to access old sessions Dec 10, 2024
@cmdcolin
Copy link
Collaborator Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment