Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If assembly is renamed, and existing session is reloaded, can go into infinite loading state #3589

Closed
cmdcolin opened this issue Mar 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

Steps to reproduce

  1. Create a small instance of jb2 with an assembly
  2. Load an LGV in the browser
  3. Rename the assembly in the config file
  4. Reload the browser
  5. Observe LGV is on an infinite loading...

I think that all assemblyNames are 'statically known' while the "assembly regions" is a lazy loaded/async operation, so I think we can do better than this

Note that in general, this type of thing is not advised for admins, as renaming identifiers including assembly "name" (which is used as identifier) and trackIds, etc can cause lots of issues with reloading sessions, but again, we may be able to do a bit better than infinite loading

@cmdcolin cmdcolin added the bug Something isn't working label Mar 16, 2023
@cmdcolin
Copy link
Collaborator Author

this was fixed recently by #4074 with the assembliesNotFound getter on the lgv model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant