Use validateToken to exchange refresh token in OAuth getFetcher

[garrettjstevens]

One tiny bugfix in this (was missing a "$" in a template literal substitution). Feel free to cherry-pick that commit out if the other commit requires more discussion.

Side note, it seems like there should be some sort of eslint rule that warns about { instead of ${ in template literals, but the closest thing I could find was disallowing backticks unless they contain a substitution or a newline:

{
  "quotes":  ["warn", "single", { "avoidEscape": true }]
}

The other commit is something where when I was reviewing #3742 I kept feeling like I'd tried to do something similar before, and I finally remembered what it was. It's possible to use validateToken to accomplish what I think is the same thing using getPreAuthorizationInformation does, which is basically making sure the refresh token for something that doesn't use RPC gets exchanged correctly. It seems to work fine in my testing.

I thought it might be a bit less confusing since getPreAuthorizationInformation was originally created specifically for RPC, so calling it in the main thread might be counterintuitive.

[codecov]

Codecov Report

Merging #3750 (be6553a) into refresh_token_refactor (bce2414) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@                   Coverage Diff                   @@
##           refresh_token_refactor    #3750   +/-   ##
=======================================================
  Coverage                   64.09%   64.10%           
=======================================================
  Files                         987      987           
  Lines                       29669    29664    -5     
  Branches                     7095     7094    -1     
=======================================================
- Hits                        19016    19015    -1     
+ Misses                      10489    10485    -4     
  Partials                      164      164           

Impacted Files	Coverage Δ
...tication/src/HTTPBasicModel/HTTPBasicLoginForm.tsx	78.57% <ø> (ø)
plugins/authentication/src/OAuthModel/model.tsx	8.33% <0.00%> (+0.25%)	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[cmdcolin]

nice! validateToken seems like a nice semantic way to do it. we could possibly add some more javadoc around this, but happy to merge

[cmdcolin]

I proposed possibly making this a new eslint rule in the unicorn set here sindresorhus/eslint-plugin-unicorn#2150

[garrettjstevens]

I proposed possibly making this a new eslint rule in the unicorn set here sindresorhus/eslint-plugin-unicorn#2150

ooh, that would be nice if someone implemented a rule like that.