Avoid re-prompting a user login when refresh token is processed #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
commented
Jun 7, 2023
| // may want to improve handling | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| this.useEndpointForAuthorization(resolve, reject) | ||
| if (doUserFlow) { |
There was a problem hiding this comment.
Only prompts the user flow if !refreshToken or refreshToken fails
cmdcolin
added
bug
Codecov Report
@@ Coverage Diff @@
## main #3749 +/- ##
==========================================
- Coverage 64.10% 64.09% -0.02%
==========================================
Files 987 987
Lines 29668 29669 +1
Branches 7099 7095 -4
==========================================
- Hits 19019 19016 -3
- Misses 10485 10489 +4
Partials 164 164
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
refresh_token_refactor
branch
from
2bb0941 to
bce2414
Compare
* Add missing "$" in template * Use validateToken to ensure refresh token is exchanged
|
maybe can just go ahead with merge, and test on main...I think it should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the oauth PR
Also does a couple refactors
a) disables the need to have any config slot for "hasRefreshToken". it is just there or not in the responses, and eagerly attempted to use
b) misc immutable js syntax sugar
c) adds more console.error logs where before they were silent, which may make the log noisier but may improve debugging