Make pluginManager param to getFetcher optional #3183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getFetcher
is supposed to be an alternative toopenLocation
for things like adapters that need to e.g. call a REST API instead of reading a file. This makes thepluginManager
param forgetFetcher
optional so that its function signature and logic matchesopenLocation
.I found this while trying to use
getFetcher
in an adapter that retrieves sequences from the new Apollo server.