Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pluginManager param to getFetcher optional #3183

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

garrettjstevens
Copy link
Collaborator

getFetcher is supposed to be an alternative to openLocation for things like adapters that need to e.g. call a REST API instead of reading a file. This makes the pluginManager param for getFetcher optional so that its function signature and logic matches openLocation.

I found this while trying to use getFetcher in an adapter that retrieves sequences from the new Apollo server.

@garrettjstevens garrettjstevens added the enhancement New feature or request label Sep 13, 2022
@garrettjstevens garrettjstevens self-assigned this Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #3183 (3848bed) into main (c8c79c4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3183      +/-   ##
==========================================
- Coverage   59.49%   59.49%   -0.01%     
==========================================
  Files         671      671              
  Lines       28644    28645       +1     
  Branches     6934     6935       +1     
==========================================
  Hits        17043    17043              
- Misses      11279    11280       +1     
  Partials      322      322              
Impacted Files Coverage Δ
packages/core/util/io/index.ts 51.78% <0.00%> (-0.95%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator

sounds good to me!

@cmdcolin cmdcolin merged commit b1d1558 into main Sep 14, 2022
@cmdcolin cmdcolin deleted the getFetcher_optional_param branch September 14, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants