-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More usage of typography to improve consistent text styling #2094
Conversation
Note that usages of SVG would not use typography elements, so labels on svg tracks may remain in Times-new-roman in embedded views |
This adds yet more typographies carefully thru the codebase...it even in some cases uses typography with a special prop It is a little difficult to have to be so careful about being this thorough about using typography, and if one is missed it goes to times new roman, but this does help some cases |
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
==========================================
+ Coverage 61.95% 61.98% +0.02%
==========================================
Files 476 476
Lines 22791 22791
Branches 5349 5349
==========================================
+ Hits 14121 14127 +6
+ Misses 8388 8381 -7
- Partials 282 283 +1
Continue to review full report at Codecov.
|
This is a random review of some concepts related to this PR a) The usage of all:'initial' CSS block in jbrowse-react-linear-genome-view is a contributor to the instances of Times New Roman font e.g. default font showing up for divs for example So I guess to summarize
|
went ahead and merged :) the update to use scopedcssbaseline (#2104) made it so we don't strictly require that everything is wrapped in a typography but these changes still seemed worthwhile. Note: the session.DialogComponent can still get unstyled in some cases but we could look into this separately |
In jbrowse/react-linear-genome-view, if there are bare "divs with text", then the font used might be something like "Times new roman" instead of a nice font
This tries to use typographies more thoroughly to make the font's a bit better