Skip to content

Commit

Permalink
Remove usage of typography for basefeaturedetails values
Browse files Browse the repository at this point in the history
  • Loading branch information
@cmdcolin
cmdcolin committed Jul 5, 2021
1 parent 45f2e8f commit 63d3484
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 114 deletions.
6 changes: 2 additions & 4 deletions packages/core/BaseFeatureWidget/BaseFeatureDetail.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,11 @@ export const FieldName = ({
return description ? (
<Tooltip title={description} placement="left">
<div className={clsx(classes.fieldDescription, classes.fieldName)}>
<Typography variant="body2">{val}</Typography>
{val}
</div>
</Tooltip>
) : (
<div className={classes.fieldName}>
<Typography variant="body2">{val}</Typography>
</div>
<div className={classes.fieldName}>{val}</div>
)
}

Expand Down
18 changes: 3 additions & 15 deletions packages/core/BaseFeatureWidget/__snapshots__/index.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Position
</p>
Position
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -89,11 +85,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Length
</p>
Length
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -117,11 +109,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
score
</p>
score
</div>
<div
class="makeStyles-fieldValue"
Expand Down
72 changes: 12 additions & 60 deletions plugins/alignments/src/AlignmentsFeatureDetail/__snapshots__/index.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Position
</p>
Position
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -96,11 +92,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Name
</p>
Name
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -116,11 +108,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Length
</p>
Length
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -136,11 +124,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Type
</p>
Type
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -164,11 +148,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
seq
</p>
seq
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -184,11 +164,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
score
</p>
score
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -204,11 +180,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
qual
</p>
qual
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -234,11 +206,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
MQ
</p>
MQ
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -254,11 +222,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
CIGAR
</p>
CIGAR
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -274,11 +238,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
length_on_ref
</p>
length_on_ref
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -294,11 +254,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
template_length
</p>
template_length
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -314,11 +270,7 @@ exports[`open up a widget 1`] = `
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
seq_length
</p>
seq_length
</div>
<div
class="makeStyles-fieldValue"
Expand Down
42 changes: 7 additions & 35 deletions plugins/variants/src/VariantFeatureWidget/__snapshots__/VariantFeatureWidget.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Position
</p>
Position
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -96,11 +92,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Name
</p>
Name
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -116,11 +108,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
Length
</p>
Length
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -145,11 +133,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
class="makeStyles-fieldDescription makeStyles-fieldName"
title="reference base(s): Each base must be one of A,C,G,T,N (case insensitive)."
>
<p
class="MuiTypography-root MuiTypography-body2"
>
REF
</p>
REF
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -166,11 +150,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
class="makeStyles-fieldDescription makeStyles-fieldName"
title=" alternate base(s): Comma-separated list of alternate non-reference alleles"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
ALT
</p>
ALT
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -187,11 +167,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
class="makeStyles-fieldDescription makeStyles-fieldName"
title="quality: Phred-scaled quality score for the assertion made in ALT"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
QUAL
</p>
QUAL
</div>
<div
class="makeStyles-fieldValue"
Expand All @@ -207,11 +183,7 @@ exports[`VariantTrack widget renders with just the required model elements 1`] =
<div
class="makeStyles-fieldName"
>
<p
class="MuiTypography-root MuiTypography-body2"
>
INFO.MQ
</p>
INFO.MQ
</div>
<div
class="makeStyles-fieldValue"
Expand Down

0 comments on commit 63d3484

Please sign in to comment.