Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with synteny polygons displaying slightly offset #1904

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

cmdcolin
Copy link
Collaborator

Fixes #1895

Currently bpToPx overestimates the amount of times it needs to incorporate interRegionPaddingBlock to all the displayedRegions that are offscreen to the left of any particular view

It actually only needs to incorporate the interRegionPaddingBlock for any displayedRegion that is on the blocks, not ones that are off screen to the left.

A similar concept was incorporated in pxToBp (which was much needed when using show all regions in assembly) but needed to be applied to bpToPx here too.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 13, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 13, 2021
@cmdcolin cmdcolin force-pushed the fix_synteny_offset branch from f0a681a to 5aae5b2 Compare April 13, 2021 03:02
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #1904 (e0ff376) into main (a1d8401) will increase coverage by 0.04%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   58.55%   58.60%   +0.04%     
==========================================
  Files         460      460              
  Lines       21333    21357      +24     
  Branches     5066     5084      +18     
==========================================
+ Hits        12492    12516      +24     
  Misses       8534     8534              
  Partials      307      307              
Impacted Files Coverage Δ
packages/core/util/Base1DViewModel.ts 78.37% <93.75%> (+1.17%) ⬆️
...s/linear-genome-view/src/LinearGenomeView/index.ts 83.44% <93.75%> (+0.17%) ⬆️
packages/core/util/index.ts 81.28% <0.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 93.61% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d8401...e0ff376. Read the comment docs.

@rbuels rbuels merged commit 559a61c into main Apr 13, 2021
@rbuels rbuels deleted the fix_synteny_offset branch April 13, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synteny rendering may be slightly inaccurate
2 participants