-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin top-level configuration #1711
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
+ Coverage 58.93% 58.95% +0.02%
==========================================
Files 446 447 +1
Lines 20461 20471 +10
Branches 4818 4819 +1
==========================================
+ Hits 12058 12068 +10
Misses 8105 8105
Partials 298 298
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very elegant 👍
just one little rename needed I think
looks great! |
Proposal for issue 1535
Adds method to PluginManager that retrieves plugin's configuration objects if they exist
Modifies the Jbrowse Model to add the plugin's configurations
Adds optional configuration param to the base class for a JBrowse plugin
Adds a test and a test plugin to verify we are able to read and get from the configuration