Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin top-level configuration #1711

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Add plugin top-level configuration #1711

merged 6 commits into from
Feb 22, 2021

Conversation

teresam856
Copy link
Contributor

@teresam856 teresam856 commented Feb 18, 2021

Proposal for issue 1535

Adds method to PluginManager that retrieves plugin's configuration objects if they exist
Modifies the Jbrowse Model to add the plugin's configurations
Adds optional configuration param to the base class for a JBrowse plugin
Adds a test and a test plugin to verify we are able to read and get from the configuration

@teresam856 teresam856 marked this pull request as draft February 18, 2021 03:14
@teresam856 teresam856 self-assigned this Feb 18, 2021
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 18, 2021
@teresam856 teresam856 added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1711 (0cffadc) into master (dd44843) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1711      +/-   ##
==========================================
+ Coverage   58.93%   58.95%   +0.02%     
==========================================
  Files         446      447       +1     
  Lines       20461    20471      +10     
  Branches     4818     4819       +1     
==========================================
+ Hits        12058    12068      +10     
  Misses       8105     8105              
  Partials      298      298              
Impacted Files Coverage Δ
products/jbrowse-web/src/jbrowseModel.js 65.85% <ø> (ø)
packages/core/Plugin.ts 100.00% <100.00%> (+50.00%) ⬆️
packages/core/PluginManager.ts 94.11% <100.00%> (+0.17%) ⬆️
products/jbrowse-web/src/tests/TestPlugin.ts 100.00% <100.00%> (ø)
packages/core/util/analytics.ts 83.78% <0.00%> (-2.71%) ⬇️
packages/core/util/index.ts 81.87% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd44843...0cffadc. Read the comment docs.

@teresam856 teresam856 changed the title 1535 tp lvl plugin config Added plugin top-level configuration Feb 19, 2021
@teresam856 teresam856 marked this pull request as ready for review February 19, 2021 21:29
@teresam856 teresam856 linked an issue Feb 19, 2021 that may be closed by this pull request
Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very elegant 👍

just one little rename needed I think

packages/core/Plugin.ts Outdated Show resolved Hide resolved
products/jbrowse-web/src/jbrowseModel.js Show resolved Hide resolved
@teresam856 teresam856 changed the title Added plugin top-level configuration Add plugin top-level configuration Feb 22, 2021
@rbuels
Copy link
Contributor

rbuels commented Feb 22, 2021

looks great!

@rbuels rbuels merged commit 9a8e8ed into master Feb 22, 2021
@rbuels rbuels deleted the 1535_tp_lvl_plugin_config branch February 22, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin top-level configuration
2 participants