Skip to content

Commit

Permalink
rename configuration to configurationschema
Browse files Browse the repository at this point in the history
  • Loading branch information
teresam856 committed Feb 22, 2021
1 parent b87f747 commit 0cffadc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/core/Plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default abstract class Plugin {

configure(_pluginManager: PluginManager): void {}

configuration: AnyConfigurationSchemaType | undefined = undefined
configurationSchema: AnyConfigurationSchemaType | undefined = undefined
}

export type PluginConstructor = new (...args: unknown[]) => Plugin
8 changes: 4 additions & 4 deletions packages/core/PluginManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ export default class PluginManager {
}

pluginConfigurationSchemas() {
const configurationSchema: { [key: string]: unknown } = {}
const configurationSchemas: { [key: string]: unknown } = {}
this.plugins.forEach(plugin => {
if (plugin.configuration) {
configurationSchema[plugin.name] = plugin.configuration
if (plugin.configurationSchema) {
configurationSchemas[plugin.name] = plugin.configurationSchema
}
})
return configurationSchema
return configurationSchemas
}

addPlugin(plugin: Plugin) {
Expand Down
2 changes: 1 addition & 1 deletion products/jbrowse-web/src/tests/TestPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ConfigurationSchema } from '@jbrowse/core/configuration'
export default class TestPlugin extends Plugin {
name = 'TestPlugin'

configuration = ConfigurationSchema('TestPlugin', {
configurationSchema = ConfigurationSchema('TestPlugin', {
topLevelTest: {
description: 'Test for top level configuration',
type: 'string',
Expand Down

0 comments on commit 0cffadc

Please sign in to comment.