Make softclip indicator black if no seq available #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
softclip_indicator_black_if_no_seq
branch
from
b7a232a to
7a8cc52
Compare
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
- Coverage 59.51% 59.50% -0.02%
==========================================
Files 435 435
Lines 19565 19568 +3
Branches 4568 4569 +1
==========================================
- Hits 11645 11644 -1
- Misses 7626 7630 +4
Partials 294 294
Continue to review full report at Codecov.
|
cmdcolin
force-pushed
the
softclip_indicator_black_if_no_seq
branch
from
7a8cc52 to
c462f86
Compare
Comment on lines
-373
to
+378
| // Black accounts for IUPAC ambiguity code bases such as N that show in soft clipping | ||
| ctx.fillStyle = lighten(colorForBase[base] || '#000000', 0.3) | ||
| // Black accounts for IUPAC ambiguity code bases such as N that | ||
| // show in soft clipping | ||
| const baseColor = colorForBase[base] || '#000000' | ||
| ctx.fillStyle = baseColor |
There was a problem hiding this comment.
It looks like the lightening of the color of the softclipped bases was removed. We can use theme.palette.bases.<base>.light to keep that behavior.
There was a problem hiding this comment.
Forgot to mention but I propose removing the lightening. We now render the clip indicator in all cases, even when soft clip is showing, so that it is clear when bases are being drawn beyond that)
…de where text palette color might be white
garrettjstevens
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the softclip indicator is colored black if no sequence is available to draw
Also adds a FAQ entry about this
Addresses #1562