Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of local files in jbrowse-desktop #1505

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 29, 2020

fixes #1315
fixes #1344

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #1505 (52253c9) into master (ffbe57d) will decrease coverage by 0.01%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
- Coverage   59.47%   59.46%   -0.02%     
==========================================
  Files         435      435              
  Lines       19547    19550       +3     
  Branches     4581     4583       +2     
==========================================
- Hits        11626    11625       -1     
- Misses       7622     7626       +4     
  Partials      299      299              
Impacted Files Coverage Δ
packages/core/ui/FileSelector.tsx 42.30% <ø> (ø)
packages/core/util/io/ElectronLocalFile.ts 3.70% <0.00%> (-0.15%) ⬇️
...management/src/AssemblyManager/AssemblyManager.tsx 73.68% <ø> (ø)
...lot-view/src/DotplotView/components/ImportForm.tsx 12.82% <0.00%> (-0.34%) ⬇️
...ew/src/LinearSyntenyView/components/ImportForm.tsx 6.81% <0.00%> (-0.16%) ⬇️
...management/src/AssemblyManager/AssemblyAddForm.tsx 66.66% <50.00%> (ø)
...ins/wiggle/src/LinearWiggleDisplay/models/model.ts 81.98% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbe57d...52253c9. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 1, 2020

Went ahead and fixed the ts-ignores with a couple helpers

@cmdcolin cmdcolin added the bug Something isn't working label Dec 2, 2020
@cmdcolin cmdcolin merged commit 8116da7 into master Dec 2, 2020
@cmdcolin cmdcolin changed the title Fix desktop loading of local files Fix loading of local files in jbrowse-desktop Dec 2, 2020
@cmdcolin cmdcolin deleted the fix_desktop_local branch December 2, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a local file BAM track fails on desktop localPath for indexedfasta fails in electron desktop
2 participants