[BUGFIX] Take visual offset into account when resyncing vocals. #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotHyper-474
approved these changes
Sep 22, 2024
|
"VOCALS NEED RESYNC" |
|
Rejected: already fixed internally |
EliteMasterEric
added
type: minor bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3380
Briefly describe the issue(s) fixed.
When setting extreme values for Visual Offset (ex. 200 or -400), the song behaves in ways that makes it annoying to play.
For example: Setting a really high positive value makes the song skip and resemble a swing tempo, whereas setting a really high negative value causes the song to not start at all!
The code that checks if a desync occurs never took Conductor's
audioVisualOffsetparameter into account, causing the aforementioned issues!Include any relevant screenshots or videos.
Before (Visual Offset set to -150):
Before.-.Negative.Offset.mp4
Before (Visual Offset set to 150):
Before.-.Positive.Offset.mp4
After (Visual Offset set to -150):
After.-.Negative.Offset.mp4
After (Visual Offset set to 150):
After.-.Positive.Offset.mp4