Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Visual Offsets to causes the song to repeatedly skip ("Swing Mode") #3380

Open
1 of 2 tasks
gordonite opened this issue Sep 18, 2024 · 23 comments
Open
1 of 2 tasks
Assignees
Labels
status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. type: minor bug Involves a minor bug or issue.
Milestone

Comments

@gordonite
Copy link

gordonite commented Sep 18, 2024

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

While playing the v0.5.0, it appears as if the songs are sped up in both pico and bf mode. the notes are also very broken, and it gets annoying to complete a song. it happens in all of the songs, based on my testing. doesnt matter if its either story mode or freeplay

Steps to reproduce (or crash logs, errors, etc.)

  1. Open Game
  2. Pick a song from either freeplay or story mode.
  3. bug happens when the song loads.
Base.Profile.2024.09.18.-.18.36.34.01.mp4
@gordonite gordonite added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Sep 18, 2024
@gordonite
Copy link
Author

Other versions I have on my PC, like v0.4.0, work perfectly fine and lack this bug btw.

@MrMooey
Copy link

MrMooey commented Sep 19, 2024

Sounds like a swing rhythm remix of 2hot which is funny

@ChillyBeanBAM
Copy link

ChillyBeanBAM commented Sep 19, 2024

This is probably due to lag spikes, but yeah, I have this problem too.

@gordonite
Copy link
Author

This is probably due to lag spikes, but yeah, I have this problem too.

Do you think it could be happening because of old hardware? My pc is old, but I'm curious as it doesn't seem like people that record on Youtube have the issue.

Makes sense either way, game does lag.

@ChillyBeanBAM
Copy link

This is probably due to lag spikes, but yeah, I have this problem too.

Do you think it could be happening because of old hardware? My pc is old, but I'm curious as it doesn't seem like people that record on Youtube have the issue.

Makes sense either way, game does lag.

I dunno, but it is possible. Then again, I don't have this problem in previous versions, so...

@gordonite
Copy link
Author

This is probably due to lag spikes, but yeah, I have this problem too.

Do you think it could be happening because of old hardware? My pc is old, but I'm curious as it doesn't seem like people that record on Youtube have the issue.
Makes sense either way, game does lag.

I dunno, but it is possible. Then again, I don't have this problem in previous versions, so...

i got a frametime thingy to work
image

it doesn't look like it could be a lag issue, but there does seem to be some micro-stutters when I'm playing.

@MrMooey
Copy link

MrMooey commented Sep 19, 2024

This is probably due to lag spikes, but yeah, I have this problem too.

Do you think it could be happening because of old hardware? My pc is old, but I'm curious as it doesn't seem like people that record on Youtube have the issue.
Makes sense either way, game does lag.

I dunno, but it is possible. Then again, I don't have this problem in previous versions, so...

i got a frametime thingy to work image

it doesn't look like it could be a lag issue, but there does seem to be some micro-stutters when I'm playing.

Could you try getting this graph for the previous (working) version too? To see if it's any different than this

@Hundrec
Copy link
Contributor

Hundrec commented Sep 19, 2024

Sounds like a swing rhythm remix of 2hot which is funny

A really good one at that!
Makes me want an actual implementation of "swing mode"

@MrMooey
Copy link

MrMooey commented Sep 19, 2024

Sounds like a swing rhythm remix of 2hot which is funny

A really good one at that!
Makes me want an actual implementation of "swing mode"

Yeah if it was still playable this would be a really fun feature, maybe could be added as a fun modifier

@Blue2359
Copy link

Blue2359 commented Sep 20, 2024

This actually happens because of the offset settings, this has no correlation to your performance/lag spikes!

(Visual Offset set to 150, for instance causes this, AND a visual offset of -150 completely causes the song to keep looping the first few milliseconds, lol!)

This only applies to Visual Offsets, not Input Offsets.

Edit: Someone on Twitter has also encountered this issue: https://twitter.com/D1ngo3K/status/1836873973935624479

@gordonite
Copy link
Author

This actually happens because of the offset settings, this has no correlation to your performance/lag spikes!

(Visual Offset set to 150, for instance causes this, AND a visual offset of -150 completely causes the song to keep looping the first few milliseconds, lol!)

This only applies to Visual Offsets, not Input Offsets.

Edit: Someone on Twitter has also encountered this issue: https://twitter.com/D1ngo3K/status/1836873973935624479

I know I might sound dumb, but how could I fix this?

@EliteMasterEric EliteMasterEric changed the title Bug Report: Speed Bug Bug Report: Setting Visual Offsets to a high positive value causes the song to repeatedly skip Sep 21, 2024
@EliteMasterEric EliteMasterEric added status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage The bug or PR has not been reviewed yet. labels Sep 21, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 21, 2024
@EliteMasterEric EliteMasterEric changed the title Bug Report: Setting Visual Offsets to a high positive value causes the song to repeatedly skip Setting Visual Offsets to causes the song to repeatedly skip ("Swing Mode") Sep 21, 2024
@Blue2359
Copy link

This actually happens because of the offset settings, this has no correlation to your performance/lag spikes!

(Visual Offset set to 150, for instance causes this, AND a visual offset of -150 completely causes the song to keep looping the first few milliseconds, lol!)

This only applies to Visual Offsets, not Input Offsets.

Edit: Someone on Twitter has also encountered this issue: https://twitter.com/D1ngo3K/status/1836873973935624479

I know I might sound dumb, but how could I fix this?

By setting your Visual Offsets to 0.

@gordonite
Copy link
Author

This actually happens because of the offset settings, this has no correlation to your performance/lag spikes!

(Visual Offset set to 150, for instance causes this, AND a visual offset of -150 completely causes the song to keep looping the first few milliseconds, lol!)

This only applies to Visual Offsets, not Input Offsets.

Edit: Someone on Twitter has also encountered this issue: https://twitter.com/D1ngo3K/status/1836873973935624479

I know I might sound dumb, but how could I fix this?

By setting your Visual Offsets to 0.

Thanks. All fixed now, Sorry for any troubles caused or time taken up over a small issue.

@AbnormalPoof
Copy link
Contributor

Oh... that explains a lot.
Screenshot 2024-09-21 at 5 18 50 PM

@EliteMasterEric
Copy link
Member

Fixed internally

@EliteMasterEric EliteMasterEric added status: pending pull request Has a PR which resolves it that is pending review. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels Sep 22, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 22, 2024
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Sep 30, 2024

While the visual offset doesn't seem to cause this anymore, setting both visual+input offsets to high values still messes with the resync.

(Bot Play because it's almost impossible to not die with this)
omagawhadahell.mp4

@Hundrec
Copy link
Contributor

Hundrec commented Sep 30, 2024

This is hilarious

@NotHyper-474
Copy link
Contributor

Oh my god it's even worse if you set only input offsets

8mb.video-dWi-yFMMw8Ns.mp4

@Hundrec
Copy link
Contributor

Hundrec commented Sep 30, 2024

Wait, post this one in #3495

@EliteMasterEric EliteMasterEric added status: resolved The issue has been clarified or fixed. status: reviewing internally This PR is under internal review and quality assurance testing status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending pull request Has a PR which resolves it that is pending review. status: resolved The issue has been clarified or fixed. status: reviewing internally This PR is under internal review and quality assurance testing labels Oct 1, 2024
@EliteMasterEric EliteMasterEric modified the milestones: 0.5.1, 0.5.2 Oct 1, 2024
@Average-FNF-Modder
Copy link

I real hope they make this a feature man, swing mode is so cool.

@AbnormalPoof
Copy link
Contributor

AbnormalPoof commented Oct 5, 2024

I real hope they make this a feature man, swing mode is so cool.

HScript and Polymod:

@Hundrec
Copy link
Contributor

Hundrec commented Oct 5, 2024

I real hope they make this a feature man, swing mode is so cool.

Context for readers: This feature was rejected in this issue: #3403

@AbnormalPoof
Copy link
Contributor

Fixed in v0.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

9 participants