feat: Implement ldc based automatic contract chunking #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
changed the base branch from
master
to
kayagokalp/deploy-default-proxy
|
based on #6069 |
Benchmark for 5e70df3Click to view benchmark
|
JoshuaBatty
reviewed
Jul 10, 2024
8 tasks
kayagokalp
force-pushed
the
kayagokalp/proxy-with-chunks
branch
from
4af06f8
to
45a0358
Compare
kayagokalp
commented
Aug 8, 2024
kayagokalp
added
enhancement
sdankel
reviewed
Aug 9, 2024
sdankel
reviewed
Aug 9, 2024
sdankel
reviewed
Aug 9, 2024
sdankel
reviewed
Aug 10, 2024
kayagokalp
changed the title
JoshuaBatty
reviewed
Aug 16, 2024
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
JoshuaBatty
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Nice work Kaya looks great. Just wondering if we can add a small section to the forc client documentation explaining that this process is going on automatically behind the scenes for large contracts. This then can help explain why they might see different outputs from forc during deployment.
alfiedotwtf
previously approved these changes
Aug 16, 2024
## Description Test should all pass once FuelLabs/fuels-rs#1483 is released ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
sdankel
approved these changes
Aug 17, 2024
Voxelot
approved these changes
Aug 17, 2024
calldelegation
approved these changes
Aug 17, 2024
IGI-111
added a commit
that referenced
this pull request
Aug 19, 2024
## Description To be merged after #6250 ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com> Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds chunk deployment based on LDC. Contracts larger than 100 kb size, is split into chunks and chunks are deployed as
blobs. Out of these blobs we create a loader contract, which loads all the blobs usingLDCopcode.One important thing is that this feature works nicely with the proxy feature introduced in #6069, so a large contract, with proxy can be deployed directly. Large contract will be split into chunks, chunks will get deployed, loader will get get generated and deployed, after all these a proxy contract is deployed and pointed to the loader contract deployed.
Simple chunked deploy, chunked deployment re routing the call, chunked deployment behind a proxy re routes the call is tested.