Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logic duplicatation between forc-client and sdk #6199

Open
kayagokalp opened this issue Jun 28, 2024 · 1 comment
Open

Remove logic duplicatation between forc-client and sdk #6199

kayagokalp opened this issue Jun 28, 2024 · 1 comment
Assignees
@kayagokalp
Labels
code quality forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy

Comments

@kayagokalp
Copy link
Member

We are already depending on sdk for some features, and for others we are re-implementing them from scratch creating two places to update for each change in fuel-core. We should make our best to re-use logic from sdk.
@kayagokalp kayagokalp added code quality forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy labels Jun 28, 2024
@kayagokalp kayagokalp self-assigned this Jun 28, 2024
@kayagokalp kayagokalp mentioned this issue Jun 28, 2024
Merged
@sdankel
Copy link
Member

sdankel commented Sep 6, 2024

@kayagokalp I know you replaced some duplicate logic as part of #6250, is there more? What code specifically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
code quality forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kayagokalp @sdankel