Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owned Proxy - update to support forc deploy proxy feature #17

Merged
merged 27 commits into from
Sep 9, 2024

Conversation

K1-R1
Copy link
Member

@K1-R1 K1-R1 commented Aug 21, 2024

Type of change

  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

  • The Owned Proxy contract has been updated to forc v0.63.3, with the standardized storage slot for target and proxy_owner pinned with the new in keyword.
  • The Owned Proxy scripts have been updated to fuel-rs v0.66.3
  • The test harness is updated to use forc v0.63.3 and fuel-rs v0.66.3
  • README badges have been updated
  • The "versions in use" note has been removed from the root README and project specific forc version badges are now used.

Notes

  • An unused test file that was copied from sway-libs/upgradeability has been removed

Related Issues

Closes #11
Closes #13
Closes #23
Closes #24

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@K1-R1 K1-R1 added the enhancement New feature or request label Aug 21, 2024
@K1-R1 K1-R1 requested a review from luizstacio August 21, 2024 23:27
@K1-R1 K1-R1 self-assigned this Aug 21, 2024
@K1-R1 K1-R1 marked this pull request as ready for review August 21, 2024 23:28
@K1-R1 K1-R1 requested a review from a team as a code owner August 21, 2024 23:28
@K1-R1
Copy link
Member Author

K1-R1 commented Aug 21, 2024

Blocked by FuelLabs/sway#6447 and the error that the Sway repo is facing:

failed to run custom build command for fuel-core-upgradable-executor v0.33.0

@K1-R1
Copy link
Member Author

K1-R1 commented Sep 5, 2024

Seeking to debug the CI issues here in #25

@K1-R1 K1-R1 added the blocked label Sep 5, 2024
@K1-R1 K1-R1 removed the blocked label Sep 8, 2024
@bitzoic bitzoic enabled auto-merge (squash) September 9, 2024 06:28
@bitzoic bitzoic merged commit 9b10f24 into master Sep 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SRC-14
Projects
None yet
4 participants