-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fee estimation error messages #1479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
helciofranco
commented
Sep 17, 2024
- Closes Dapp Approve Screen - avoid showing errors of fee estimation #1457
📷 Demo |
---|
![]() |
…t/add-switch-network-experience
helciofranco
commented
Sep 17, 2024
LuizAsFight
approved these changes
Sep 18, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Sep 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## fuels-wallet@0.29.0 ### Minor Changes - [#1479](#1479) [`14e63852`](14e6385) Thanks [@helciofranco](https://github.com/helciofranco)! - Improve how error messages are displayed/parsed during fee estimation. - [#1479](#1479) [`14e63852`](14e6385) Thanks [@helciofranco](https://github.com/helciofranco)! - Display fees options even when there are tx simulation errors. ### Patch Changes - [#1481](#1481) [`926a64f4`](926a64f) Thanks [@helciofranco](https://github.com/helciofranco)! - Blocks leading zeros in the amount field. - [#1481](#1481) [`926a64f4`](926a64f) Thanks [@helciofranco](https://github.com/helciofranco)! - Blocks leading zeros in the Gas Limit input during the fee customization. - [#1480](#1480) [`65a987b1`](65a987b) Thanks [@helciofranco](https://github.com/helciofranco)! - Improve gas error message by adding number formatting for better readability. - [#1481](#1481) [`926a64f4`](926a64f) Thanks [@helciofranco](https://github.com/helciofranco)! - Blocks leading zeros in the Tip input during the fee customization. - [#1479](#1479) [`14e63852`](14e6385) Thanks [@helciofranco](https://github.com/helciofranco)! - Allow dApps to pass account owner with `0x` address. - Updated dependencies \[]: - @fuel-wallet/connections@0.29.0 ## @fuel-wallet/connections@0.29.0 ## @fuel-wallet/types@0.29.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.