Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapp Approve Screen - avoid showing errors of fee estimation #1457

Closed
LuizAsFight opened this issue Sep 6, 2024 · 0 comments · Fixed by #1479
Closed

Dapp Approve Screen - avoid showing errors of fee estimation #1457

LuizAsFight opened this issue Sep 6, 2024 · 0 comments · Fixed by #1479
Assignees
@helciofranco

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Sep 6, 2024 •
edited by helciofranco
Loading

this errors mainly started to happen after we included fee calculation/customization on approval screen

one possible solution to it is to handle the estimation inside a try {} catch {} , and in case it fails, use the gasLimit / maxFee that was already in the transaction request, avoiding to break the flow

How to reproduce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helciofranco helciofranco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fee estimation error messages FuelLabs/fuels-wallet
3 participants
@helciofranco @rodrigobranas @LuizAsFight