Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction revert error with status change #2901

Closed
wants to merge 10 commits into from

Conversation

petertonysmith94
Copy link
Contributor

Release notes

In this release, we:

  • Fixed bug with transaction reverting with unknown reason.

Summary

  • Within our transaction flow, we listen to the statusChange subscription. Once a change of status occurs, we perform a getTransactionWithReceipts query.
  • The statusChange subscription was posting a SuccessStatus, but the sub-sequential call to the getTransactionWithReceipts query returned a SubmittedStatus, which the SDK interprets as an erroneous condition.
  • This change uses the transaction posted from the statusChange for SuccessStatus and FailureStatus results.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@petertonysmith94 petertonysmith94 added bug Issue is a bug blocked labels Aug 9, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 9, 2024
@petertonysmith94
Copy link
Contributor Author

This change will require the release of fuel core 0.32.1 - therefore blocked.

@petertonysmith94 petertonysmith94 changed the title Ps/bug/transaction from status fix: transaction revert error with status change Aug 9, 2024
@petertonysmith94
Copy link
Contributor Author

petertonysmith94 commented Aug 9, 2024

Pulled must the schema changes from:

@nedsalk
Copy link
Contributor

nedsalk commented Aug 13, 2024

Closing this as I've taken the issue and will open up a new PR soon.

@nedsalk nedsalk closed this Aug 13, 2024
@arboleya arboleya deleted the ps/bug/transaction-from-status branch August 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction succeeds with a revert error Use receipts from TransactionStatus
2 participants