Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use receipts from TransactionStatus #1644

Closed
nedsalk opened this issue Jan 15, 2024 Discussed in #1588 · 6 comments · Fixed by #2962
Closed

Use receipts from TransactionStatus #1644

nedsalk opened this issue Jan 15, 2024 Discussed in #1588 · 6 comments · Fixed by #2962
Assignees
Labels
feat Issue is a feature

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Jan 15, 2024

Discussed in #1588

Originally posted by nedsalk December 15, 2023
Post fuel-core v0.22.0, the node now returns receipts with a TransactionStatus, so we can use them right away instead of running another fetch. From my understanding, this will only become relevant after #1374 is merged, because we're currently using the getTransactionWithReceipts endpoint.

The way to go about implementing this is to use the TransactionRequest sent to the node in provider.sendTransaction because it contains the same transaction as the one that's fetched from the node inside of TransactionResponse via getTransactionWithReceipts, only that after fetching it from the node the receipts are there as well.

Because the receipts can now be received from the subscription directly, the same transaction summary can be generated based off of the TransactionRequest and the receipts received from the subscription. A working implementation can be found on this branch.

@nedsalk nedsalk added the feat Issue is a feature label Jan 15, 2024
@nedsalk nedsalk self-assigned this Jan 15, 2024
@nedsalk

This comment was marked as resolved.

@arboleya arboleya added this to the 2 - Beetle milestone Jan 15, 2024
@arboleya

This comment was marked as off-topic.

@nedsalk

This comment was marked as off-topic.

@arboleya

This comment was marked as off-topic.

@nedsalk
Copy link
Contributor Author

nedsalk commented Mar 4, 2024

Blocked by:

@arboleya
Copy link
Member

arboleya commented Aug 8, 2024

Unblocked by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
3 participants