Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: enhance TX error handling and message formatting #1895

Merged
merged 53 commits into from
Apr 4, 2024
Merged

chore!: enhance TX error handling and message formatting #1895

merged 53 commits into from
Apr 4, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Mar 19, 2024 •
edited
Loading

Breaking Changes:

  • The ScriptResultDecoderError along with all revert error-related classes and its helpers were removed.

@Torres-ssf Torres-ssf added the chore Issue is a chore label Mar 19, 2024
@Torres-ssf Torres-ssf self-assigned this Mar 19, 2024
@Torres-ssf
Copy link
Contributor Author

Blocked by: #1940

@Torres-ssf Torres-ssf marked this pull request as draft April 1, 2024 15:37
@Torres-ssf Torres-ssf mentioned this pull request Apr 2, 2024
Closed
@Torres-ssf Torres-ssf marked this pull request as ready for review April 3, 2024 00:41
petertonysmith94
petertonysmith94 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Torres-ssf Torres-ssf requested a review from maschad as a code owner April 4, 2024 02:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Coverage Report:

Lines Branches Functions Statements
81.45%(+0.16%) 72%(+0.26%) 79.46%(+0.69%) 81.52%(+0.13%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 68.75%
(-1.46%)		 45%
(+0%)		 87.5%
(+0%)		 68.75%
(-1.46%)
🔴 ✨ packages/account/src/providers/utils/extract-tx-error.ts 9.75%
(+9.75%)		 0%
(+0%)		 0%
(+0%)		 8.88%
(+8.88%)
🔴 packages/program/src/utils.ts 0%
(-10.52%)		 0%
(+0%)		 0%
(+0%)		 0%
(-10.52%)

@Torres-ssf Torres-ssf enabled auto-merge (squash) April 4, 2024 11:05
@Torres-ssf Torres-ssf merged commit e995aab into master Apr 4, 2024
15 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/refact-tx-error-assembling branch April 4, 2024 11:05
@fuel-service-user fuel-service-user mentioned this pull request Apr 4, 2024
Merged
@danielbate danielbate mentioned this pull request Apr 4, 2024
Merged
6 tasks
@nedsalk nedsalk mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@maschad maschad Awaiting requested review from maschad

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supply better error messaging on Reverts
7 participants
@Torres-ssf @fuel-service-user @arboleya @danielbate @petertonysmith94 @nedsalk @Dhaiwat10