Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TxPool tests and documentation #2327

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improve TxPool tests and documentation #2327

wants to merge 10 commits into from
+360 −32

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Oct 10, 2024 •
edited
Loading

Linked Issues/PRs

Closes #762

Description

This PR improves the tests to make sure all the structures that stores transactions/caches have the expected state after the execution of a test.

We also added an high level documentation for users and contributors at the root of the pool

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT changed the title Prepare txpool testing Improve TxPool tests and documentation Oct 10, 2024
@AurelienFT AurelienFT self-assigned this Oct 10, 2024
@AurelienFT AurelienFT marked this pull request as ready for review October 10, 2024 19:28
@AurelienFT AurelienFT requested a review from a team October 11, 2024 13:39
acerone85
acerone85 reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@acerone85 acerone85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but mostly minor things.
Overall looks good

acerone85
acerone85 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@acerone85 acerone85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acerone85 acerone85 acerone85 approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@AurelienFT AurelienFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @acerone85