Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxPool test suite must cover success cases and failure cases #762

Open
bvrooman opened this issue Nov 7, 2022 · 2 comments
Open

TxPool test suite must cover success cases and failure cases #762

bvrooman opened this issue Nov 7, 2022 · 2 comments
Assignees
@bvrooman
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@bvrooman
Copy link
Contributor

bvrooman commented Nov 7, 2022

Currently, the TxPool test suite covers:

  • Simple success cases (simple insertion, simple dependency chains)
  • Most error cases

The TxPool test suite does not cover:

  • Complex dependency chains
  • All error cases (there are more Error variants than tests)
  • Stress testing (high volume, high concurrency, etc.)
  • Benchmarking
@bvrooman bvrooman self-assigned this Nov 7, 2022
@bvrooman bvrooman added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Nov 7, 2022
@bvrooman bvrooman mentioned this issue Nov 7, 2022
Merged
@Voxelot Voxelot linked a pull request Dec 12, 2022 that will close this issue
[WIP] txpool test coverage #773
Closed
@xgreenx
Copy link
Collaborator

xgreenx commented Sep 19, 2024

Transaction Pool V2 improves the test coverage #2193

@xgreenx xgreenx closed this as completed Sep 19, 2024
@AurelienFT
Copy link
Contributor

I think this can still be open as I improved a bit but mainly reordered and simplified and there is points like benchmarks that I don't have and should be done.

@AurelienFT AurelienFT reopened this Sep 19, 2024
@AurelienFT AurelienFT mentioned this issue Sep 19, 2024
Closed
@AurelienFT AurelienFT mentioned this issue Oct 10, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvrooman bvrooman

Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] txpool test coverage FuelLabs/fuel-core
3 participants
@bvrooman @xgreenx @AurelienFT