chore(gas_price_service): initialize v1 metadata #2288

rymnc · 2024-10-04T08:02:17Z

Note

This is PR 1/n in introducing GasPriceServiceV1 which links to v1 of the gas-price-algorithm. This PR is mainly used to start the discussion around v1 metadata and the fields we need.

Linked Issues/PRs

fixes #2286

Description

Specifies a V1Metadata that will be stored along V0Metadata wrapped within the UpdaterMetadata struct.
We use fallible conversions between the two, v0 => v1 should be possible
Constructor for AlgorithmUpdaterV1 from V1Metadata

Bonus:

Also fixed the tests that were testing initialize_algorithm to test the UninitializedTask instead--a public interface.

Checklist

Breaking changes are clearly marked as such in the PR description and changelog
New behavior is reflected in tests
The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

I have reviewed the code myself
I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Rust SDK
Sway compiler
Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
Someone else?

rymnc · 2024-10-04T08:04:03Z

crates/services/gas_price_service/src/v1/metadata.rs

+pub struct V1Metadata {
+    // Execution
+    /// The gas price (scaled by the `gas_price_factor`) to cover the execution of the next block
+    pub new_scaled_exec_price: u64,
+    /// The lowest the algorithm allows the exec gas price to go
+    pub min_exec_gas_price: u64,
+    /// The Percentage the execution gas price will change in a single block, either increase or decrease
+    /// based on the fullness of the last L2 block. Using `u16` because it can go above 100% and
+    /// possibly over 255%
+    pub exec_gas_price_change_percent: u16,
+    /// The height of the next L2 block
+    pub l2_block_height: u32,
+    /// The threshold of gas usage above and below which the gas price will increase or decrease
+    /// This is a percentage of the total capacity of the L2 block
+    pub l2_block_fullness_threshold_percent: ClampedPercentage,
+    // DA
+    /// The gas price (scaled by the `gas_price_factor`) to cover the DA commitment of the next block
+    pub new_scaled_da_gas_price: u64,
+
+    /// Scale factor for the gas price.
+    pub gas_price_factor: NonZeroU64,
+    /// The lowest the algorithm allows the da gas price to go
+    pub min_da_gas_price: u64,
+    /// The maximum percentage that the DA portion of the gas price can change in a single block
+    ///   Using `u16` because it can go above 100% and possibly over 255%
+    pub max_da_gas_price_change_percent: u16,
+    /// The cumulative reward from the DA portion of the gas price
+    pub total_da_rewards_excess: u128,
+    /// The height of the last L2 block recorded on the DA chain
+    pub da_recorded_block_height: u32,
+    /// The cumulative cost of recording L2 blocks on the DA chain as of the last recorded block
+    pub latest_known_total_da_cost_excess: u128,
+    /// The predicted cost of recording L2 blocks on the DA chain as of the last L2 block
+    /// (This value is added on top of the `latest_known_total_da_cost` if the L2 height is higher)
+    pub projected_total_da_cost: u128,
+    /// The P component of the PID control for the DA gas price
+    pub da_p_component: i64,
+    /// The D component of the PID control for the DA gas price
+    pub da_d_component: i64,
+    /// The last profit
+    pub last_profit: i128,
+    /// The profit before last
+    pub second_to_last_profit: i128,
+    /// The latest known cost per byte for recording blocks on the DA chain
+    pub latest_da_cost_per_byte: u128,
+}


cc: @MitchTurner, if you can describe which ones we need and which ones are just being used/mutated internally by the AlgorithmUpdater please

/// Same as with V0, but we need to multiply it by the `gas_price_factor`. A constructor would help a lot here :) pub new_scaled_exec_price: u64, /// Same as with V0 (this isn't scaled, I double checked. pub min_exec_gas_price: u64, /// Same as V0 pub exec_gas_price_change_percent: u16, /// Should be confirmed with metadata sync pub l2_block_height: u32, /// Same as V0 pub l2_block_fullness_threshold_percent: ClampedPercentage, /// Should be defined in config. Should be multiplied by `gas_price_factor`. Again, constructor would be good. pub new_scaled_da_gas_price: u64, /// `100` should be good and we can hardcode it if we want. pub gas_price_factor: NonZeroU64, /// Should be set with config pub min_da_gas_price: u64, /// Should be set with config pub max_da_gas_price_change_percent: u16, /// Zero on start (saved in Metadata) pub total_da_rewards_excess: u128, /// Currently the correct value is required here on startup, i.e. we should know what we expect next from the committer and do the block before that. BUT I think we should allow it to start with None. (saved in Metadata) pub da_recorded_block_height: u32, /// Zero on start (saved in Metadata) pub latest_known_total_da_cost_excess: u128, /// Zero on start (saved in Metadata) pub projected_total_da_cost: u128, /// Set with Config pub da_p_component: i64, /// Set with Config pub da_d_component: i64, /// Zero on start (saved in Metadata) pub last_profit: i128, /// Zero on start (saved in Metadata) pub second_to_last_profit: i128, /// Zero on start (saved in Metadata) pub latest_da_cost_per_byte: u128,

this is super useful, making the required changes!

lmk if bcb1fd3 makes sense, then i will open the PR for review from others :)

I just realized that I put (saved in Metadata) on a few of them, but there are others that I missed.

what's the action here? should I change the metadata?

bump @MitchTurner

Sorry. Missed this. I just updated.

rymnc · 2024-10-04T08:09:18Z

I have the rest of the code for GasPriceServiceV1, getting them out in chunks though

…the config

MitchTurner · 2024-10-24T20:07:56Z

So. I wanted to remove the unneeded fields from the metadatas, this let me to modifying how the tests work... which led me to fixing some of the tests. I don't know if we want to keep that in this PR.

crates/services/gas_price_service/src/v0/uninitialized_task.rs

netrome

Looks mostly good to me. There are a few dangling todos that need to be addressed. Beyond that I just have a few questions and suggestions.

netrome · 2024-10-29T11:58:05Z

crates/fuel-core/src/service/adapters/gas_price_adapters.rs

+        // TODO: we need to alter fuel-core configuration to include versioned config, after which
+        // we can directly pass it into the constructor.


Should we do it now or create a follow-up?

I'm removing the TODO. We need to decide if we are going to specify like that or just switch it to the new version and never support the old version. We're tracking the work regardless.

netrome · 2024-10-29T12:00:33Z

crates/services/gas_price_service/src/ports.rs

-    pub starting_gas_price: u64,
-    pub gas_price_change_percent: u64,
-    pub gas_price_threshold_percent: u64,
+pub enum VersionSpecificConfig {


Nit: I'd prefer the old name here GasPriceServiceConfig. The fact that it's versioned is clear enough given the V0 and V1 variants, and any code which doesn't match on the version variants shouldn't have to care if it's versioned or not.

Suggested change

pub enum VersionSpecificConfig {

pub enum GasPriceServiceConfig

netrome · 2024-10-29T12:02:54Z

crates/services/gas_price_service/src/ports.rs

+        Self::V1(metadata)
+    }
+
+    /// Extract V0MetadataInitializer if it is of V0 version


What's V0MetadataInitializer?

netrome · 2024-10-29T12:04:32Z

crates/services/gas_price_service/src/v0/tests.rs

@@ -91,27 +116,28 @@ impl MetadataStorage for ErroringMetadata {
    }
 }

+fn arb_config() -> V0AlgorithmConfig {


Nit: While we already use the arb abbreviation for the arb_metadata(), I find it easier to read if we spell out the full word:

Suggested change

fn arb_config() -> V0AlgorithmConfig {

fn arbitrary_config() -> V0AlgorithmConfig {

netrome · 2024-10-29T12:07:48Z

crates/services/gas_price_service/src/ports.rs

+pub struct GasPriceServiceConfig {
+    version_specific_config: VersionSpecificConfig,
+}


What's the point of wrapping VersionSpecificCoinfig here as opposed to just having a single enum?

pub enum GasPriceServiceConfig { V0(...) V1(...) }

netrome · 2024-10-29T12:09:46Z

crates/services/gas_price_service/src/ports.rs

+    pub fn new_v1(metadata: V1AlgorithmConfig) -> Self {
+        Self::V1(metadata)
+    }


Nit: I'd complement these constructors with with From<VXAlgorithmConfig> implementations.

netrome · 2024-10-29T12:14:56Z

crates/services/gas_price_service/src/v0/tests.rs

+// GasPriceData + Modifiable + KeyValueInspect<Column = GasPriceColumn>
+impl GasPriceData for FakeGasPriceDb {
+    fn latest_height(&self) -> Option<BlockHeight> {
+        todo!()


Dangling todo. Shuld we remove this function or when is it to be implemented?

It's fine. It just doesn't get called in the scope of any of these tests, but we're still required to pass something that implements that trait.

I can change to unimplemented if that's better.

Yeah then unimplemented conveys the intention better.

crates/services/gas_price_service/src/v1/metadata.rs

AurelienFT

Nice first step towards new gas price 🚀 WP. LGTM.

netrome

Thanks for updating! 🙏

@acerone85

## Version v0.41.0 ### Added - [2547](#2547): Replace the old Graphql gas price provider adapter with the ArcGasPriceEstimate. - [2445](#2445): Added GQL endpoint for querying asset details. - [2442](#2442): Add uninitialized task for V1 gas price service - [2154](#2154): Added `Unknown` variant to `ConsensusParameters` graphql queries - [2154](#2154): Added `Unknown` variant to `Block` graphql queries - [2154](#2154): Added `TransactionType` type in `fuel-client` - [2321](#2321): New metrics for the TxPool: - The size of transactions in the txpool (`txpool_tx_size`) - The time spent by a transaction in the txpool in seconds (`txpool_tx_time_in_txpool_seconds`) - The number of transactions in the txpool (`txpool_number_of_transactions`) - The number of transactions pending verification before entering the txpool (`txpool_number_of_transactions_pending_verification`) - The number of executable transactions in the txpool (`txpool_number_of_executable_transactions`) - The time it took to select transactions for inclusion in a block in microseconds (`txpool_select_transactions_time_microseconds`) - The time it took to insert a transaction in the txpool in microseconds (`transaction_insertion_time_in_thread_pool_microseconds`) - [2385](#2385): Added new histogram buckets for some of the TxPool metrics, optimize the way they are collected. - [2347](#2364): Add activity concept in order to protect against infinitely increasing DA gas price scenarios - [2362](#2362): Added a new request_response protocol version `/fuel/req_res/0.0.2`. In comparison with `/fuel/req/0.0.1`, which returns an empty response when a request cannot be fulfilled, this version returns more meaningful error codes. Nodes still support the version `0.0.1` of the protocol to guarantee backward compatibility with fuel-core nodes. Empty responses received from nodes using the old protocol `/fuel/req/0.0.1` are automatically converted into an error `ProtocolV1EmptyResponse` with error code 0, which is also the only error code implemented. More specific error codes will be added in the future. - [2386](#2386): Add a flag to define the maximum number of file descriptors that RocksDB can use. By default it's half of the OS limit. - [2376](#2376): Add a way to fetch transactions in P2P without specifying a peer. - [2361](#2361): Add caches to the sync service to not reask for data it already fetched from the network. - [2327](#2327): Add more services tests and more checks of the pool. Also add an high level documentation for users of the pool and contributors. - [2416](#2416): Define the `GasPriceServiceV1` task. - [2447](#2447): Use new `expiration` policy in the transaction pool. Add a mechanism to prune the transactions when they expired. - [1922](#1922): Added support for posting blocks to the shared sequencer. - [2033](#2033): Remove `Option<BlockHeight>` in favor of `BlockHeightQuery` where applicable. - [2490](#2490): Added pagination support for the `balances` GraphQL query, available only when 'balances indexation' is enabled. - [2439](#2439): Add gas costs for the two new zk opcodes `ecop` and `eadd` and the benches that allow to calibrate them. - [2472](#2472): Added the `amountU128` field to the `Balance` GraphQL schema, providing the total balance as a `U128`. The existing `amount` field clamps any balance exceeding `U64` to `u64::MAX`. - [2526](#2526): Add possibility to not have any cache set for RocksDB. Add an option to either load the RocksDB columns families on creation of the database or when the column is used. - [2532](#2532): Getters for inner rocksdb database handles. - [2524](#2524): Adds a new lock type which is optimized for certain workloads to the txpool and p2p services. - [2535](#2535): Expose `backup` and `restore` APIs on the `CombinedDatabase` struct to create portable backups and restore from them. - [2550](#2550): Add statistics and more limits infos about txpool on the node_info endpoint ### Fixed - [2560](#2560): Fix flaky test by increasing timeout - [2558](#2558): Rename `cost` and `reward` to remove `excess` wording - [2469](#2469): Improved the logic for syncing the gas price database with on_chain database - [2365](#2365): Fixed the error during dry run in the case of race condition. - [2366](#2366): The `importer_gas_price_for_block` metric is properly collected. - [2369](#2369): The `transaction_insertion_time_in_thread_pool_milliseconds` metric is properly collected. - [2413](#2413): block production immediately errors if unable to lock the mutex. - [2389](#2389): Fix construction of reverse iterator in RocksDB. - [2479](#2479): Fix an error on the last iteration of the read and write sequential opcodes on contract storage. - [2478](#2478): Fix proof created by `message_receipts_proof` function by ignoring the receipts from failed transactions to match `message_outbox_root`. - [2485](#2485): Hardcode the timestamp of the genesis block and version of `tai64` to avoid breaking changes for us. - [2511](#2511): Fix backward compatibility of V0Metadata in gas price db. ### Changed - [2469](#2469): Updated adapter for querying costs from DA Block committer API - [2469](#2469): Use the gas price from the latest block to estimate future gas prices - [2501](#2501): Use gas price from block for estimating future gas prices - [2468](#2468): Abstract unrecorded blocks concept for V1 algorithm, create new storage impl. Introduce `TransactionableStorage` trait to allow atomic changes to the storage. - [2295](#2295): `CombinedDb::from_config` now respects `state_rewind_policy` with tmp RocksDB. - [2378](#2378): Use cached hash of the topic instead of calculating it on each publishing gossip message. - [2438](#2438): Refactored service to use new implementation of `StorageRead::read` that takes an offset in input. - [2429](#2429): Introduce custom enum for representing result of running service tasks - [2377](#2377): Add more errors that can be returned as responses when using protocol `/fuel/req_res/0.0.2`. The errors supported are `ProtocolV1EmptyResponse` (status code `0`) for converting empty responses sent via protocol `/fuel/req_res/0.0.1`, `RequestedRangeTooLarge`(status code `1`) if the client requests a range of objects such as sealed block headers or transactions too large, `Timeout` (status code `2`) if the remote peer takes too long to fulfill a request, or `SyncProcessorOutOfCapacity` if the remote peer is fulfilling too many requests concurrently. - [2233](#2233): Introduce a new column `modification_history_v2` for storing the modification history in the historical rocksDB. Keys in this column are stored in big endian order. Changed the behaviour of the historical rocksDB to write changes for new block heights to the new column, and to perform lookup of values from the `modification_history_v2` table first, and then from the `modification_history` table, performing a migration upon access if necessary. - [2383](#2383): The `balance` and `balances` GraphQL query handlers now use index to provide the response in a more performant way. As the index is not created retroactively, the client must be initialized with an empty database and synced from the genesis block to utilize it. Otherwise, the legacy way of retrieving data will be used. - [2463](#2463): The `coinsToSpend` GraphQL query handler now uses index to provide the response in a more performant way. As the index is not created retroactively, the client must be initialized with an empty database and synced from the genesis block to utilize it. Otherwise, the legacy way of retrieving data will be used. - [2556](#2556): Ensure that the `last_recorded_height` is set for the DA gas price source. #### Breaking - [2469](#2469): Move from `GasPriceServicev0` to `GasPriceServiceV1`. Include new config values. - [2438](#2438): The `fuel-core-client` can only work with new version of the `fuel-core`. The `0.40` and all older versions are not supported. - [2438](#2438): Updated `fuel-vm` to `0.59.1` release. Check [release notes](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.59.0) for more details. - [2389](#2258): Updated the `messageProof` GraphQL schema to return a non-nullable `MessageProof`. - [2154](#2154): Transaction graphql endpoints use `TransactionType` instead of `fuel_tx::Transaction`. - [2446](#2446): Use graphiql instead of graphql-playground due to known vulnerability and stale development. - [2379](#2379): Change `kv_store::Value` to be `Arc<[u8]>` instead of `Arc<Vec<u8>>`. - [2490](#2490): Updated GraphQL complexity calculation for `balances` query to account for pagination (`first`/`last`) and nested field complexity (`child_complexity`). Queries with large pagination values or deeply nested fields may have higher complexity costs. - [2463](#2463): 'CoinsQueryError::MaxCoinsReached` variant has been removed. The `InsufficientCoins` variant has been renamed to `InsufficientCoinsForTheMax` and it now contains the additional `max` field - [2463](#2463): The number of excluded ids in the `coinsToSpend` GraphQL query is now limited to the maximum number of inputs allowed in transaction. - [2463](#2463): The `coinsToSpend` GraphQL query may now return different coins, depending whether the indexation is enabled or not. However, regardless of the differences, the returned coins will accurately reflect the current state of the database within the context of the query. - [2526](#2526): By default the cache of RocksDB is now disabled instead of being `1024 * 1024 * 1024`. ## What's Changed * Add metrics to TxPool by @acerone85 in #2321 * Fix collection of gas price metric by @rafal-ch in #2366 * Add documentation to run a ignition node in readme by @AurelienFT in #2363 * Fix collection of tx pool insertion time metric by @rafal-ch in #2369 * Add versioning to request response protocols by @acerone85 in #2362 * Return reason of why proof cant be generated by @rafal-ch in #2258 * p2p: use precalculated topic hash by @yaziciahmet in #2378 * Remove ignore RUSTSEC-2024-0336 by @AurelienFT in #2384 * Deal with negative feed back loop in DA gas price by @MitchTurner in #2364 * Add new flag for maximum file descriptors in rocksdb. by @AurelienFT in #2386 * Add codeowners for gas price algorithm crate by @rafal-ch in #2404 * Weekly `cargo update` by @github-actions in #2373 * chore(gas_price_service): initialize v1 metadata by @rymnc in #2288 * chore(gas_price_service_v0): remove unused trait impl by @rymnc in #2410 * Update tai64 to fix the wrong time offset by @AurelienFT in #2409 * fix(block_producer): immediately return error if lock cannot be acquired during production by @rymnc in #2413 * Add a way to fetch transactions in P2P without specifying a peer by @AurelienFT in #2376 * Add a new code owner for tx pool by @AurelienFT in #2417 * Satisfy clippy in `gas-price-analysis` by @rafal-ch in #2418 * Txpool metrics update by @rafal-ch in #2385 * Improve TxPool tests and documentation by @AurelienFT in #2327 * feat(gas_price_service_v1): define RunnableTask for GasPriceServiceV1 by @rymnc in #2416 * Return reason of why proof cant be generated (api change) by @rafal-ch in #2389 * Fuel/Request_Response v0.0.2: More meaningful error messages by @acerone85 in #2377 * Fix reverse iterator in RocksDB by @AurelienFT in #2398 * Add test node herself in reserved nodes. by @AurelienFT in #2390 * Weekly `cargo update` by @github-actions in #2424 * Weekly `cargo update` by @github-actions in #2440 * Resolve some falky tests and improve CI times by @AurelienFT in #2401 * feat: handle `Unknown` transactions, blocks and consensus parameters by @hal3e in #2154 * fix(p2p): cache responses to serve without roundtrip to db by @rymnc in #2352 * Replace task `run()` return result with custom enum by @MitchTurner in #2429 * Fix codeowners by @AurelienFT in #2444 * fix(graphql_playground): use graphiql instead by @rymnc in #2446 * Weekly `cargo update` by @github-actions in #2453 * refactor: remove `Option<BlockHeight>` and use new enum where applicable by @matt-user in #2033 * Fixed the error during dry run by @xgreenx in #2365 * Add decompression traits and a test case by @Dentosal in #2295 * Versioned Storage for Modifications History by @acerone85 in #2233 * Allow DA recorded blocks to come out-of-order by @MitchTurner in #2415 * feat: Change `kv_store::Value` to be Arc<[u8]> instead of Arc<Vec<u8>> by @netrome in #2411 * Optimize balance-related queries with a cache by @rafal-ch in #2383 * fix: Add missing features to `fuel-core-tests` by @netrome in #2467 * Keep data in fails cases in sync service by @AurelienFT in #2361 * Weekly `cargo update` by @github-actions in #2470 * Revert balances amount to `U64` and introduce new `amountU128` getter by @rafal-ch in #2472 * Create uninitialized task for v1 gas price service by @MitchTurner in #2442 * Port the 0.40.2 fix of TAI on master by @AurelienFT in #2485 * Ignore RUSTSEC-2024-0421 by @AurelienFT in #2489 * Ignore receipts from failed transactions in `message_receipts_proof` by @AurelienFT in #2478 * Add unrecorded blocks abstraction to gas price algo by @MitchTurner in #2468 * Fix last iteration in sequential opcode by @AurelienFT in #2479 * fix(gas_price_service_v0): bring back removed fields, causing UB when trying to access by @rymnc in #2511 * Refactor fuel-core to use version of StorageRead::read with offset (Full update to 0.59.1) by @acerone85 in #2438 * Sync the version of the `fuel-core` with minor hot fixes by @xgreenx in #2516 * fix(docs): typo preventing ci checks from passing by @rymnc in #2525 * Integration test for balances and (non)retryable messages by @rafal-ch in #2505 * Add document for launching Ignition node from source and Local network from source by @AurelienFT in #2502 * Make the rocksdb cache optional in config and add policy for column opening by @AurelienFT in #2526 * Weekly `cargo update` by @github-actions in #2530 * chore(rocksdb): getter for inner database handle by @rymnc in #2532 * Use gas prices from actual blocks to calculate estimate gas prices by @MitchTurner in #2501 * chore(codeowners): gas price service codeowners by @rymnc in #2534 * Add zk opcodes by @AurelienFT in #2439 * Gas price simulation data retriever by @acerone85 in #2533 * Shared sequencer integration by @Dentosal in #1922 * Use expiration policy by @AurelienFT in #2447 * Fixed TPS benchmark to work with latest changes by @xgreenx in #2515 * Use indexation cache to satisfy "coins to spend" queries by @rafal-ch in #2463 * feat(txpool|p2p): use seqlock instead of small copy-able RwLocks by @rymnc in #2524 * Create new index for tracking Asset metadata by @maschad in #2445 * feat(rocksdb): remove getters for internal rocksdb handles, expose `backup` instead by @rymnc in #2535 * Integrate with V1 algo for tests by @MitchTurner in #2469 * Lock-free `latest_l2_height` in gas price service by @rafal-ch in #2546 * chore(gas_price_service_v1): strictly ensure last_recorded_height is set, to avoid initial poll of da source by @rymnc in #2556 * Replace old Graphql Gas Price adapter with new latest gas price struct by @MitchTurner in #2547 * Rename cost and rewards without 'excess' by @MitchTurner in #2558 * Add current pool gas to the node info endpoint by @AurelienFT in #2550 * Pagination queries for `balances` endpoint by @rafal-ch in #2490 * 2559 Increase timeout for test by @MitchTurner in #2560 * Add test expiration policy in executor by @AurelienFT in #2563 ## New Contributors * @yaziciahmet made their first contribution in #2378 **Full Changelog**: v0.40.0...v0.41.0

rymnc self-assigned this Oct 4, 2024

rymnc commented Oct 4, 2024

View reviewed changes

rymnc force-pushed the chore/gas-price-service-v1-metadata branch 3 times, most recently from bcb1fd3 to cfb7b1b Compare October 7, 2024 05:30

rymnc added 4 commits October 7, 2024 11:01

chore(gas_price_service): initialize v1 metadata

8297189

chore: changelog

1b7c91e

fix: broken test

56731ca

fix: move things around, introduce versioned configuration

298de5f

rymnc force-pushed the chore/gas-price-service-v1-metadata branch from cfb7b1b to 298de5f Compare October 7, 2024 05:33

rymnc and others added 12 commits October 7, 2024 11:10

fix: cyclic dep between service and uninit task

6d1a673

Merge branch 'master' into chore/gas-price-service-v1-metadata

c980dfe

Merge branch 'master' into chore/gas-price-service-v1-metadata

c04f2c5

Fix compilation

d22c9bb

Remove unused fields in metadata

48718ad

Merge branch 'master' into chore/gas-price-service-v1-metadata

67ccb14

Fix compilation more, add new field to v1 updater

9e8750f

remove unneeded fields from v1 metadata because we can get them from …

5f96e64

…the config

Remove commented code

e3af4c4

Remove more commented code

d530dd0

Use uninitialized task instead of the helper function in test

30e5bfd

Fix the other one

8a5ab27

MitchTurner marked this pull request as ready for review October 24, 2024 20:04

MitchTurner requested review from xgreenx and Dentosal as code owners October 24, 2024 20:04

MitchTurner added 3 commits October 25, 2024 11:53

Fix integration compilation

75b68c3

Create function for converting old metadata into new metadata

4419e4d

Create function for converting metadata into updater

21ea106

MitchTurner added 2 commits October 25, 2024 15:46

Add missing fields to config and metadata, include in conversions

3266a17

Fix test name

daad75e

rymnc commented Oct 28, 2024

View reviewed changes

crates/services/gas_price_service/src/v0/uninitialized_task.rs Show resolved Hide resolved

rymnc assigned MitchTurner Oct 28, 2024

MitchTurner added 4 commits October 28, 2024 17:41

Merge branch 'master' into chore/gas-price-service-v1-metadata

5689168

Fix one test

eba0dd0

Fix the other test and hopefully not break any others

c57c0ba

Lint a little

b11b09c

netrome requested changes Oct 29, 2024

View reviewed changes

Remove redundant type, simplify constructors, other PR suggestions

10b00f6

AurelienFT reviewed Oct 29, 2024

View reviewed changes

crates/services/gas_price_service/src/v1/metadata.rs Outdated Show resolved Hide resolved

crates/services/gas_price_service/src/v1/metadata.rs Show resolved Hide resolved

MitchTurner added 2 commits October 29, 2024 17:10

Clarify comment

068789e

Merge branch 'master' into chore/gas-price-service-v1-metadata

5f347ab

MitchTurner requested a review from rafal-ch as a code owner October 29, 2024 19:50

Use NonZeroU64 in config

f00b73c

AurelienFT approved these changes Oct 30, 2024

View reviewed changes

netrome approved these changes Oct 30, 2024

View reviewed changes

MitchTurner approved these changes Oct 30, 2024

View reviewed changes

MitchTurner merged commit 7605a2a into master Oct 30, 2024
38 checks passed

MitchTurner deleted the chore/gas-price-service-v1-metadata branch October 30, 2024 08:23

xgreenx mentioned this pull request Jan 15, 2025

Release v0.41.0 #2565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(gas_price_service): initialize v1 metadata #2288

chore(gas_price_service): initialize v1 metadata #2288

rymnc commented Oct 4, 2024 •

edited

Loading

rymnc Oct 4, 2024

MitchTurner Oct 4, 2024 •

edited

Loading

rymnc Oct 4, 2024

rymnc Oct 4, 2024

MitchTurner Oct 7, 2024

rymnc Oct 7, 2024

rymnc Oct 14, 2024

MitchTurner Oct 22, 2024

rymnc commented Oct 4, 2024

MitchTurner commented Oct 24, 2024

netrome left a comment

netrome Oct 29, 2024

MitchTurner Oct 29, 2024

netrome Oct 29, 2024

netrome Oct 29, 2024

netrome Oct 29, 2024

netrome Oct 29, 2024

netrome Oct 29, 2024

netrome Oct 29, 2024

MitchTurner Oct 29, 2024

MitchTurner Oct 29, 2024

netrome Oct 29, 2024

AurelienFT left a comment •

edited

Loading

netrome left a comment

		// TODO: we need to alter fuel-core configuration to include versioned config, after which
		// we can directly pass it into the constructor.

	pub enum VersionSpecificConfig {
	pub enum GasPriceServiceConfig

	fn arb_config() -> V0AlgorithmConfig {
	fn arbitrary_config() -> V0AlgorithmConfig {

chore(gas_price_service): initialize v1 metadata #2288

chore(gas_price_service): initialize v1 metadata #2288

Conversation

rymnc commented Oct 4, 2024 • edited Loading

Linked Issues/PRs

Description

Checklist

Before requesting review

After merging, notify other teams

Choose a reason for hiding this comment

MitchTurner Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rymnc commented Oct 4, 2024

MitchTurner commented Oct 24, 2024

netrome left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AurelienFT left a comment • edited Loading

Choose a reason for hiding this comment

netrome left a comment

Choose a reason for hiding this comment

rymnc commented Oct 4, 2024 •

edited

Loading

MitchTurner Oct 4, 2024 •

edited

Loading

AurelienFT left a comment •

edited

Loading