fix: Fix commit error on GraphQL service startup

CHANGELOG.md

@@ -15,6 +15,7 @@ Description of the upcoming release here.
 
 ### Fixed
 
+- [#1802](https://github.com/FuelLabs/fuel-core/pull/1802): Fixed a runtime panic that occurred when restarting a node. The panic was caused by an invalid database commit while loading an existing off-chain database. The invalid commit is removed in this PR.
 - [#1795](https://github.com/FuelLabs/fuel-core/pull/1795): Fixed the building of the `fuel-core-wasm-executor` to work outside of the `fuel-core` context. The change uses the path to the manifest file of the `fuel-core-upgradable-executor` to build the `fuel-core-wasm-executor` instead of relying on the workspace.
 
 ## [Version 0.24.1]

crates/fuel-core/src/graphql_api/ports.rs

@@ -263,6 +263,9 @@ pub mod worker {
         /// Returns the total count after the update.
         fn increase_tx_count(&mut self, new_txs_count: u64) -> StorageResult<u64>;
 
+        /// Gets the total number of transactions on the chain from metadata.
+        fn get_tx_count(&self) -> StorageResult<u64>;
+
         /// Commits the underlying changes into the database.
         fn commit(self) -> StorageResult<()>;
     }

crates/fuel-core/src/graphql_api/storage.rs

@@ -23,6 +23,7 @@ use fuel_core_storage::{
     Error as StorageError,
     Result as StorageResult,
     StorageAsMut,
+    StorageInspect,
     StorageMutate,
 };
 use fuel_core_types::{
@@ -141,6 +142,14 @@ where
         Ok(new_tx_count)
     }
 
+    fn get_tx_count(&self) -> StorageResult<u64> {
+        const TX_COUNT: &str = "total_tx_count";
+
+        let tx_count = *<_ as StorageInspect<StatisticTable<u64>>>::get(self, TX_COUNT)?
+            .unwrap_or_default();
+        Ok(tx_count)
+    }
+
     fn commit(self) -> StorageResult<()> {
         self.commit()?;
         Ok(())

crates/fuel-core/src/graphql_api/worker_service.rs

@@ -323,10 +323,11 @@ where
         _: &StateWatcher,
         _: Self::TaskParams,
     ) -> anyhow::Result<Self::Task> {
-        let mut db_tx = self.database.transaction();
-        let total_tx_count = db_tx.increase_tx_count(0).unwrap_or_default();
-        db_tx.commit()?;
-        graphql_metrics().total_txs_count.set(total_tx_count as i64);
+        {
+            let db_tx = self.database.transaction();
+            let total_tx_count = db_tx.get_tx_count().unwrap_or_default();
+            graphql_metrics().total_txs_count.set(total_tx_count as i64);
+        }
 
         // TODO: It is possible that the node was shut down before we processed all imported blocks.
         //  It could lead to some missed blocks and the database's inconsistent state.

tests/tests/health.rs

@@ -1,9 +1,11 @@
 use fuel_core::{
+    combined_database::CombinedDatabase,
     database::Database,
     service::{
         Config,
         FuelService,
     },
+    types::fuel_tx::Transaction,
 };
 use fuel_core_client::client::FuelClient;
 
@@ -41,3 +43,38 @@ async fn can_restart_node() {
             .unwrap();
     }
 }
+
+#[tokio::test]
+async fn can_restart_node_with_transactions() {
+    use fuel_core::service::ServiceTrait;
+
+    let capacity = 1024 * 1024;
+    let tmp_dir = tempfile::TempDir::new().unwrap();
+
+    {
+        let database = CombinedDatabase::open(tmp_dir.path(), capacity).unwrap();
+        let service = FuelService::from_combined_database(database, Config::local_node())
+            .await
+            .unwrap();
+        let client = FuelClient::from(service.bound_address);
+        client.health().await.unwrap();
+
+        for _ in 0..5 {
+            let tx = Transaction::default_test_tx();
+            client.submit_and_await_commit(&tx).await.unwrap();
+        }
+
+        service.stop_and_await().await.unwrap();
+    }
+
+    {
+        let database = CombinedDatabase::open(tmp_dir.path(), capacity).unwrap();
+        let service = FuelService::from_combined_database(database, Config::local_node())
+            .await
+            .unwrap();
+        let client = FuelClient::from(service.bound_address);
+        client.health().await.unwrap();
+
+        service.stop_and_await().await.unwrap();
+    }
+}