fix: Fix commit error on GraphQL service startup

[bvrooman]

Related issues:

• Closes Unable to start the node after restart on fuel-core 0.24.1 #1801

This PR removes the unnecessary DB commit that occurs during startup of the GraphQL API service. Because the committed transaction has no corresponding change in block height, the state transition fails and throws an error. This error then causes startup of the Fuel node to fail.

This can currently happen in local and production builds, but we did not have coverage for this in test. This is because this requires loading the off-chain database using something like CombinedDatabase::open(...), while most tests in the codebase use a default off-chain database, i.e. from_database:

    pub async fn from_database(
        database: Database,
        config: Config,
    ) -> anyhow::Result<Self> {
        let combined_database =
            CombinedDatabase::new(database, Default::default(), Default::default());
        Self::from_combined_database(combined_database, config).await
    }

This PR introduces a test that performs the following steps:

1. Creates a node using a RocksDB database on the filesystem for on-chain, off-chain, and relayer ("combined") data
2. Sends some transactions to the node
3. Shuts down the node
4. Creates a second node by loading the same database on the filesystem for on-chain, off-chain, and relayer data
5. Waits for the second node to become healthy

Before removing the commit, this test failed with the observed failure:

The initialization of the service failed.: error occurred in the underlying datastore `NewHeightIsNotSet { prev_height: 3 }`

With the code change, this test passes.

[xgreenx]

It would be nice to move it on one level upper. And reuse inside of the increase_tx_count

[bvrooman]

By one level up, do you mean the Transactional trait?

[xgreenx]

I mean reuse one constant in two functions=) Define it on file level instead of function level

The base branch was changed.

[Voxelot]

if we aren't doing a commit here, do we still need a transaction?

[xgreenx]

No, we don't, but it will require changing of constraints for the port=D I'm okay with using transaction for now to just fix the issue and release a new fuel-core with the fix=)