Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #447

Merged
merged 51 commits into from
Oct 6, 2022
Merged

Various updates #447

merged 51 commits into from
Oct 6, 2022

Conversation

richardfrost
Copy link
Collaborator

@richardfrost richardfrost commented Oct 5, 2022

✨ New Features & Updates:

🔧 Development:

  • Common functions for using APF Captions
  • 7088e04 Add filteredText to FilteredVTTCue
  • d4c1e40 Add source/destination to extension messages
  • fe5eaa3 Store tab's status and use for badge color

Add option to control filtering for "[ _ ]" on YouTube (On by default)
The previous commit would increase the number of times we have to filter the text for each time we split, but isn't necessary to filter. This change will only split when APF Captions are in use, restoring the original behavior
To make the clean() method more succinct and only filter each element once (helpful with large wordlists), this now splits the results (if they have the same number of newlines).
enabledFramesOnly:
  false (default):
    framesOff:
      true: filtering for frames disabled on current domain
      false: filtering for frames enabled on current domain
  true:
    framesOn:
      true: filtering for frames enabled on current domain
      false: filtering for frames disabled on current domain
@richardfrost richardfrost marked this pull request as draft October 5, 2022 04:33
@richardfrost richardfrost self-assigned this Oct 5, 2022
@richardfrost richardfrost marked this pull request as ready for review October 6, 2022 14:49
@richardfrost richardfrost merged commit 8986691 into main Oct 6, 2022
@richardfrost richardfrost deleted the various_updates branch October 6, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant