Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insane Memory Usage On Safari #435

Closed
GameParrot opened this issue Sep 2, 2022 · 5 comments
Closed

Insane Memory Usage On Safari #435

GameParrot opened this issue Sep 2, 2022 · 5 comments
Labels
Bug Something isn't working

Comments

@GameParrot
Copy link

🐛 Description

When using the extension, the RAM usage is insanely high, When running the test at https://browserbench.org/JetStream/, it goes over 4 GB with the extension and rarely over 600 MB without the extension.

🔀 Steps To Reproduce

  1. Open Activity Monitor and switch to the Memory tab
  2. Go to https://browserbench.org/JetStream/
  3. Run the test
  4. See the insane memory usage in Activity Monitor

✔️ Expected behavior

The memory usage should not be insanely high

📷 Screenshots

If applicable, add screenshots to help explain your problem.

💻 Details

@GameParrot GameParrot added the Bug Something isn't working label Sep 2, 2022
@richardfrost
Copy link
Collaborator

After a few tests with this, I don't really think there is anything that I can really do to prevent this. The memory usage appears to come as the its creating hundreds of new documents rapidly, and the browser injects a new instance of APF each time. The easiest fix here would probably be to just disable the extension for the page, because its working as its intended to. Benchmarks definitely push what they are benchmarking to their limits, and in this case that appears to be what is happening.

@GameParrot
Copy link
Author

The extension seems to affect performance when browsing on sites even that are not benchmarks, especially ones with a lot of ads. Maybe disabling the extension on ads/iframes should be an option?

@richardfrost
Copy link
Collaborator

@GameParrot That's not a bad idea. I will add it to the backlog to look into that. My first thought is to implement it like the "Domain mode", which controls the overall strategy, and then allow specific domains to change that behavior.

This was referenced Oct 5, 2022
@richardfrost
Copy link
Collaborator

Okay, this option has been added and should now be available in version 2.38.1. Let me know how it goes for you.

@richardfrost
Copy link
Collaborator

@GameParrot Just wanted to check with you and see if this option helped at all for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants