Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a fix for filament sensor activation for material as default #582

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Surion79
Copy link
Contributor

in case the filament_sensor setting is missing in the material, it is defaulted to 1.
I used this approach to remove a variable and use a single variable to define on start_print if the sensor is enabled or not.

@Surion79 Surion79 requested a review from Frix-x April 18, 2024 15:51
@Surion79 Surion79 linked an issue Apr 18, 2024 that may be closed by this pull request
1 task
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

1 similar comment
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge

@Frix-x Frix-x merged commit cfd9305 into develop Jun 18, 2024
@Frix-x Frix-x deleted the MaterialFilamentSensorFix branch June 18, 2024 08:48
tehniemer added a commit to tehniemer/klippain that referenced this pull request Aug 22, 2024
* added custom4..9 in start_print (Frix-x#539)

* updated beeper sections (Frix-x#549)

by switching to pwm_cycle_time instead of output pin

* removed M204 in favor of SET_VELOCITY_LIMIT (Frix-x#555)

* support for LDO Picobilical (Frix-x#533)

* removed M204 for SET_VELOCITY_LIMIT (Frix-x#554)

* removed last M204 for SET_VELOCITY_LIMIT (Frix-x#553)

* removed old artifacts from TMC2240 init feature

Please use https://github.com/andrewmcgr/klipper_tmc_autotune instead!

* Message update to show "Available RAM" rather than "Used RAM" (Frix-x#579)

* fixed max_z bug in PARK macro

* Update BTT_SKR_2.cfg to fix EXP1_4 typo (Frix-x#578)

* added a fix for filament sensor activation for material as default (Frix-x#582)

* code cleanup in some templates (removed extra spaces) (Frix-x#570)

* Nozzle cleaning parameters update (Frix-x#569)

* add expander templates support (Frix-x#567)

with Klipper expander and Arduino nano templates as first expanders

* Reset layers stats on start print (Frix-x#565)

* optional setting for adaptive primeline (Frix-x#522)

* fix typo in qgl.cfg

* added AWD support (2x X, 2x Y) (Frix-x#508)

* add built in adxl sensor from nitehawk sb board (Frix-x#602)

* Update LDO_Nitehawk-SB_v1.0.cfg (Frix-x#594)

* add: mcu Fystec Cheetah v3 (Frix-x#604)

* fixed default pins for SB2209 v1.0 (Frix-x#609)

* added function for pause at (next) layer (Frix-x#606)

* Add FYSETC Nozzle-Input-Shaper accelerometer support (Frix-x#603)

---------

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Colten Edwards <cd.edwards@sasktel.net>
Co-authored-by: Nick Danyluk <ndanyluk7@gmail.com>
Co-authored-by: Christian Johnson <cjohnson-phys@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: o1hitman1o <o1hitman1o@gmail.com>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: dev-aphex <dev-aphex@users.noreply.github.com>
Co-authored-by: Minims <github@minims.fr>
tehniemer added a commit to tehniemer/klippain that referenced this pull request Aug 22, 2024
* added custom4..9 in start_print (Frix-x#539)

* updated beeper sections (Frix-x#549)

by switching to pwm_cycle_time instead of output pin

* removed M204 in favor of SET_VELOCITY_LIMIT (Frix-x#555)

* support for LDO Picobilical (Frix-x#533)

* removed M204 for SET_VELOCITY_LIMIT (Frix-x#554)

* removed last M204 for SET_VELOCITY_LIMIT (Frix-x#553)

* removed old artifacts from TMC2240 init feature

Please use https://github.com/andrewmcgr/klipper_tmc_autotune instead!

* Message update to show "Available RAM" rather than "Used RAM" (Frix-x#579)

* fixed max_z bug in PARK macro

* Update BTT_SKR_2.cfg to fix EXP1_4 typo (Frix-x#578)

* added a fix for filament sensor activation for material as default (Frix-x#582)

* code cleanup in some templates (removed extra spaces) (Frix-x#570)

* Nozzle cleaning parameters update (Frix-x#569)

* add expander templates support (Frix-x#567)

with Klipper expander and Arduino nano templates as first expanders

* Reset layers stats on start print (Frix-x#565)

* optional setting for adaptive primeline (Frix-x#522)

* fix typo in qgl.cfg

* added AWD support (2x X, 2x Y) (Frix-x#508)

* add built in adxl sensor from nitehawk sb board (Frix-x#602)

* Update LDO_Nitehawk-SB_v1.0.cfg (Frix-x#594)

* add: mcu Fystec Cheetah v3 (Frix-x#604)

* fixed default pins for SB2209 v1.0 (Frix-x#609)

* added function for pause at (next) layer (Frix-x#606)

* Add FYSETC Nozzle-Input-Shaper accelerometer support (Frix-x#603)

---------

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Colten Edwards <cd.edwards@sasktel.net>
Co-authored-by: Nick Danyluk <ndanyluk7@gmail.com>
Co-authored-by: Christian Johnson <cjohnson-phys@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: o1hitman1o <o1hitman1o@gmail.com>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: dev-aphex <dev-aphex@users.noreply.github.com>
Co-authored-by: Minims <github@minims.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix filament sensor variable
2 participants