Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expander_templates #567

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Expander_templates #567

merged 8 commits into from
Jun 18, 2024

Conversation

Benoitone
Copy link
Collaborator

Add Klipper Expander and Arduino nano templates in new expand mcu section.
Add also section in install script

@Benoitone Benoitone mentioned this pull request Mar 22, 2024
Closed
@Benoitone Benoitone added the user template This issue or PR refer to one of the user template file label Mar 25, 2024
@Foose83
Copy link

Foose83 commented Apr 1, 2024

Bonjour, ça ma l'air vraiment très bien.
Merci beaucoup.

Foose83
Foose83 approved these changes Apr 6, 2024
View reviewed changes
Copy link

@Foose83 Foose83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout a l'ait très bien.

@Surion79
Copy link
Contributor

Surion79 commented Apr 6, 2024

would it be possible to name the folder "expander" instead of "expand"? currently Klippain uses noms for templates, not verbs

Benoitone
Benoitone commented Apr 7, 2024
View reviewed changes
Copy link
Collaborator Author

@Benoitone Benoitone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to name the folder "expander" instead of "expand"? currently Klippain uses noms for templates, not verbs

done

Surion79
Surion79 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Surion79 Surion79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. can't test it though. using multiple expander boards require additional work when it is greater than 1?

@Surion79 Surion79 linked an issue Apr 18, 2024 that may be closed by this pull request
Klipper expander #562
Closed
@Surion79 Surion79 changed the title Expand_templates Expander_templates Apr 18, 2024
@github-actions GitHub Actions
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@Foose83
Copy link

Foose83 commented Jun 4, 2024

Bonjour, je voudrez le tester mais je n'y arrive pas, je ne sais pas comment faire.
J'ai essayé mais j'ai des erreurs, je pense que je n'ai pas bien procédé.

Frix-x
Frix-x approved these changes Jun 18, 2024
View reviewed changes
Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge :)

@Frix-x Frix-x merged commit 6079072 into develop Jun 18, 2024
@Frix-x Frix-x deleted the expand_templates branch June 18, 2024 08:57
tehniemer added a commit to tehniemer/klippain that referenced this pull request Aug 22, 2024
@tehniemer @Frix-x
@Surion79 @cdedwards @ndanyluk @cjohnson-phys @tsk-2222 @o1hitman1o @ksummers92 @Benoitone @dev-aphex @Minims
Prime line (#33)
4274e34 
* added custom4..9 in start_print (Frix-x#539)

* updated beeper sections (Frix-x#549)

by switching to pwm_cycle_time instead of output pin

* removed M204 in favor of SET_VELOCITY_LIMIT (Frix-x#555)

* support for LDO Picobilical (Frix-x#533)

* removed M204 for SET_VELOCITY_LIMIT (Frix-x#554)

* removed last M204 for SET_VELOCITY_LIMIT (Frix-x#553)

* removed old artifacts from TMC2240 init feature

Please use https://github.com/andrewmcgr/klipper_tmc_autotune instead!

* Message update to show "Available RAM" rather than "Used RAM" (Frix-x#579)

* fixed max_z bug in PARK macro

* Update BTT_SKR_2.cfg to fix EXP1_4 typo (Frix-x#578)

* added a fix for filament sensor activation for material as default (Frix-x#582)

* code cleanup in some templates (removed extra spaces) (Frix-x#570)

* Nozzle cleaning parameters update (Frix-x#569)

* add expander templates support (Frix-x#567)

with Klipper expander and Arduino nano templates as first expanders

* Reset layers stats on start print (Frix-x#565)

* optional setting for adaptive primeline (Frix-x#522)

* fix typo in qgl.cfg

* added AWD support (2x X, 2x Y) (Frix-x#508)

* add built in adxl sensor from nitehawk sb board (Frix-x#602)

* Update LDO_Nitehawk-SB_v1.0.cfg (Frix-x#594)

* add: mcu Fystec Cheetah v3 (Frix-x#604)

* fixed default pins for SB2209 v1.0 (Frix-x#609)

* added function for pause at (next) layer (Frix-x#606)

* Add FYSETC Nozzle-Input-Shaper accelerometer support (Frix-x#603)

---------

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Colten Edwards <cd.edwards@sasktel.net>
Co-authored-by: Nick Danyluk <ndanyluk7@gmail.com>
Co-authored-by: Christian Johnson <cjohnson-phys@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: o1hitman1o <o1hitman1o@gmail.com>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: dev-aphex <dev-aphex@users.noreply.github.com>
Co-authored-by: Minims <github@minims.fr>
tehniemer added a commit to tehniemer/klippain that referenced this pull request Aug 22, 2024
@tehniemer @Frix-x
@Surion79 @cdedwards @ndanyluk @cjohnson-phys @tsk-2222 @o1hitman1o @ksummers92 @Benoitone @dev-aphex @Minims
Retract length (#34)
54be56c 
* added custom4..9 in start_print (Frix-x#539)

* updated beeper sections (Frix-x#549)

by switching to pwm_cycle_time instead of output pin

* removed M204 in favor of SET_VELOCITY_LIMIT (Frix-x#555)

* support for LDO Picobilical (Frix-x#533)

* removed M204 for SET_VELOCITY_LIMIT (Frix-x#554)

* removed last M204 for SET_VELOCITY_LIMIT (Frix-x#553)

* removed old artifacts from TMC2240 init feature

Please use https://github.com/andrewmcgr/klipper_tmc_autotune instead!

* Message update to show "Available RAM" rather than "Used RAM" (Frix-x#579)

* fixed max_z bug in PARK macro

* Update BTT_SKR_2.cfg to fix EXP1_4 typo (Frix-x#578)

* added a fix for filament sensor activation for material as default (Frix-x#582)

* code cleanup in some templates (removed extra spaces) (Frix-x#570)

* Nozzle cleaning parameters update (Frix-x#569)

* add expander templates support (Frix-x#567)

with Klipper expander and Arduino nano templates as first expanders

* Reset layers stats on start print (Frix-x#565)

* optional setting for adaptive primeline (Frix-x#522)

* fix typo in qgl.cfg

* added AWD support (2x X, 2x Y) (Frix-x#508)

* add built in adxl sensor from nitehawk sb board (Frix-x#602)

* Update LDO_Nitehawk-SB_v1.0.cfg (Frix-x#594)

* add: mcu Fystec Cheetah v3 (Frix-x#604)

* fixed default pins for SB2209 v1.0 (Frix-x#609)

* added function for pause at (next) layer (Frix-x#606)

* Add FYSETC Nozzle-Input-Shaper accelerometer support (Frix-x#603)

---------

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Colten Edwards <cd.edwards@sasktel.net>
Co-authored-by: Nick Danyluk <ndanyluk7@gmail.com>
Co-authored-by: Christian Johnson <cjohnson-phys@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: o1hitman1o <o1hitman1o@gmail.com>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: dev-aphex <dev-aphex@users.noreply.github.com>
Co-authored-by: Minims <github@minims.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Surion79 Surion79 Surion79 approved these changes

@Foose83 Foose83 Foose83 approved these changes

@Frix-x Frix-x Frix-x approved these changes

Assignees
No one assigned
Labels
user template This issue or PR refer to one of the user template file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Klipper expander
4 participants
@Benoitone @Foose83 @Surion79 @Frix-x