Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey picker #65

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

merge main

c0952a3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Hotkey picker #65

merge main
c0952a3
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana for .NET failed Jan 29, 2025 in 0s

6249 new problems found by Qodana for .NET

Qodana for .NET

51 new problems were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 16
Nullability conflicts with annotations in hierarchy 🔶 Warning 4
Redundant namespace alias 🔶 Warning 2
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 1
Redundant member initializer 🔶 Warning 1
Redundant class or interface specification in base types list 🔶 Warning 1
Unused local variable 🔶 Warning 1
Use preferred style of 'new' expression when created type is evident ◽️ Notice 9
Invert 'if' statement to reduce nesting ◽️ Notice 6
Use preferred style for trailing comma before new line in multiline lists ◽️ Notice 2
Field can be made readonly (private accessibility) ◽️ Notice 2
Redundant empty argument list on object creation expression ◽️ Notice 2
Use collection expression syntax ◽️ Notice 2
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 1
Use preferred 'var' style (when type is simple) ◽️ Notice 1 
@@ Code coverage @@
+ 21% total lines covered
7820 lines analyzed, 1717 lines covered
! 20% fresh lines covered
172 lines analyzed, 36 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 6 dependencies

Third-party software list

This page lists the third-party software dependencies used in SoulSplitter

Dependency Version Licenses
MaterialDesignColors 2.1.4 MIT
MaterialDesignThemes 4.9.0 MIT
Microsoft.CSharp 4.7.0 MIT
Microsoft.NETCore.Platforms 1.1.0 MIT
Microsoft.Xaml.Behaviors.Wpf 1.1.39 MIT
NETStandard.Library 2.0.3 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check notice on line 30 in src/SoulSplitter/Hotkeys/GlobalHotKey.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 106 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 456 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 466 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 467 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 465 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 468 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 29 in src/SoulSplitter/Hotkeys/GlobalHotKey.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 462 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style of 'new' expression when created type is evident 

Redundant type specification

Check notice on line 30 in src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style for trailing comma before new line in multiline lists 

Remove trailing comma to conform to code style

Check notice on line 116 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Use preferred style for trailing comma before new line in multiline lists 

Remove trailing comma to conform to code style

Check warning on line 80 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations 

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check notice on line 32 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Field can be made readonly (private accessibility) 

Field can be made readonly

Check notice on line 106 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Field can be made readonly (private accessibility) 

Field can be made readonly

Check notice on line 39 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used 

Part of loop's body can be converted into LINQ-expression but another 'GetEnumerator' method will be used

Check notice on line 54 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invert 'if' statement to reduce nesting 

Invert 'if' statement to reduce nesting

Check notice on line 97 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invert 'if' statement to reduce nesting 

Invert 'if' statement to reduce nesting

Check notice on line 52 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invert 'if' statement to reduce nesting 

Invert 'if' statement to reduce nesting

Check notice on line 41 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invert 'if' statement to reduce nesting 

Invert 'if' statement to reduce nesting

Check notice on line 121 in src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invert 'if' statement to reduce nesting 

Invert 'if' statement to reduce nesting

Check notice on line 36 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Invert 'if' statement to reduce nesting 

Invert 'if' statement to reduce nesting

Check warning on line 34 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Nullability conflicts with annotations in hierarchy 

Nullability of a member conflicts with annotations in hierarchy

Check warning on line 54 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Nullability conflicts with annotations in hierarchy 

Nullability of a member conflicts with annotations in hierarchy

Check warning on line 54 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Nullability conflicts with annotations in hierarchy 

Nullability of a member conflicts with annotations in hierarchy

Check warning on line 34 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Nullability conflicts with annotations in hierarchy 

Nullability of a member conflicts with annotations in hierarchy
View more details on GitHub Actions