build

Hotkey picker #563

Sign in to view logs

Triggered via pull request January 29, 2025 21:23

FrankvdStam

synchronize #65

feature/hotkeypicker-ui

Status Success

Total duration 15m 11s

Artifacts 1

build.yml

on: pull_request

Annotations

1 error, 26 warnings, and 25 notices

The number of problems exceeds the failThreshold

Conditional access qualifier expression is not null according to nullable reference types' annotations: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L80

Conditional access qualifier expression is never null according to nullable reference types' annotations

Nullability conflicts with annotations in hierarchy: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L34

Nullability of a member conflicts with annotations in hierarchy

Nullability conflicts with annotations in hierarchy: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L54

Nullability of a member conflicts with annotations in hierarchy

Nullability conflicts with annotations in hierarchy: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L54

Nullability of a member conflicts with annotations in hierarchy

Nullability conflicts with annotations in hierarchy: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L34

Nullability of a member conflicts with annotations in hierarchy

Redundant member initializer: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L47

Initializing field by default value is redundant

Redundant class or interface specification in base types list: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L31

Base type 'UserControl' is already specified in other parts

Redundant using directive: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L18

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L24

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/Hotkeys/Hotkey.cs#L17

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/Hotkeys/Hotkey.cs#L19

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L19

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/Hotkeys/Hotkey.cs#L18

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L21

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L21

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L17

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/Hotkeys/Hotkey.cs#L20

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L19

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/Hotkeys/Hotkey.cs#L21

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L22

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L18

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L20

Using directive is not required by the code and can be safely removed

Redundant using directive: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L18

Using directive is not required by the code and can be safely removed

Unused local variable: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L89

Local variable 'converter' is never used

Redundant namespace alias: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml#L24

Namespace alias 'materialDesign' is not required by code and can be safely removed

Redundant namespace alias: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml#L25

Namespace alias 'validation' is not required by code and can be safely removed

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/Hotkeys/GlobalHotKey.cs#L30

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L106

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L456

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L466

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L467

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L465

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L468

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/Hotkeys/GlobalHotKey.cs#L29

Redundant type specification

Use preferred style of 'new' expression when created type is evident: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L462

Redundant type specification

Use preferred style for trailing comma before new line in multiline lists: src/SoulSplitter/UI/EldenRing/FpsPatchHotkey.cs#L30

Remove trailing comma to conform to code style

Use preferred style for trailing comma before new line in multiline lists: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L116

Remove trailing comma to conform to code style

Field can be made readonly (private accessibility): src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L32

Field can be made readonly

Field can be made readonly (private accessibility): src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L106

Field can be made readonly

Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L39

Part of loop's body can be converted into LINQ-expression but another 'GetEnumerator' method will be used

Invert 'if' statement to reduce nesting: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L54

Invert 'if' statement to reduce nesting

Invert 'if' statement to reduce nesting: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L97

Invert 'if' statement to reduce nesting

Invert 'if' statement to reduce nesting: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L52

Invert 'if' statement to reduce nesting

Invert 'if' statement to reduce nesting: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L41

Invert 'if' statement to reduce nesting

Invert 'if' statement to reduce nesting: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L121

Invert 'if' statement to reduce nesting

Invert 'if' statement to reduce nesting: src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs#L36

Invert 'if' statement to reduce nesting

Redundant empty argument list on object creation expression: src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L106

Empty argument list is redundant

Redundant empty argument list on object creation expression: src/SoulSplitter/Hotkeys/GlobalHotKey.cs#L112

Empty argument list is redundant

Use preferred 'var' style (when type is simple): src/SoulSplitter/UI/Generic/HotkeyPicker.xaml.cs#L57

Use 'var' (simple types)

Use collection expression syntax: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L462

Use collection expression

Use collection expression syntax: src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs#L456

Use collection expression

Artifacts

Produced during runtime

Name	Size
1.7.5	8.85 MB