Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of Chinese character search, refactor pinyin alphabet and bugfix #1545

Merged
merged 4 commits into from
Nov 20, 2022
Merged

Allow the use of Chinese character search, refactor pinyin alphabet and bugfix #1545

merged 4 commits into from
Nov 20, 2022

Conversation

VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Nov 16, 2022 •
edited by jjw24
Loading

  1. Fix Pinyin transformation does not cover query #995, can now search in Chinese even if Pinyin search is enabled
  2. Refactored Fix Pinyin transformation does not cover query#995 #1539
  3. Remove legacy pinyin database

Tests:

  • Pinyin query can search Chinese results when ShouldUsePinyin is true.
  • Chinese query can search Chinese results when ShouldUsePinyin is true.
  • Pinyin query can't search Chinese results when ShouldUsePinyin is false.
  • Chinese query can search Chinese results when ShouldUsePinyin is false.

@VictoriousRaptor VictoriousRaptor mentioned this pull request Nov 16, 2022
Closed
@VictoriousRaptor VictoriousRaptor self-assigned this Nov 16, 2022
@VictoriousRaptor VictoriousRaptor added bug Something isn't working Code Refactor labels Nov 16, 2022
@VictoriousRaptor VictoriousRaptor merged commit 3dceb7b into Flow-Launcher:dev Nov 20, 2022
@VictoriousRaptor VictoriousRaptor deleted the RefactorPinyin branch November 20, 2022 18:24
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 23, 2022
@jjw24 jjw24 changed the title Refactor pinyin alphabet and bugfix Allow the use of Chinese character search, refactor pinyin alphabet and bugfix Nov 23, 2022
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taooceros taooceros taooceros approved these changes

Assignees

@VictoriousRaptor VictoriousRaptor

Labels
bug Something isn't working Code Refactor
Projects
Work In Progress
Archived in project
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Pinyin transformation does not cover query
3 participants
@VictoriousRaptor @taooceros @jjw24