Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinyin transformation does not cover query #995

Closed
photkey opened this issue Jan 25, 2022 · 6 comments · Fixed by #1545
Closed

Pinyin transformation does not cover query #995

photkey opened this issue Jan 25, 2022 · 6 comments · Fixed by #1545
Assignees
@VictoriousRaptor
Labels
enhancement New feature or request
Milestone
1.10.0

Comments

@photkey
Copy link

photkey commented Jan 25, 2022

Favorite

Windows build number:版本 21H2 (OS 内部版本 22000.434)
Flow Launcher version: 1.9.1
@photkey photkey added the bug Something isn't working label Jan 25, 2022
@photkey
Copy link
Author

photkey commented Jan 25, 2022

Tried again, the Chinese title search can not, the English can be searched.

@taooceros
Copy link
Member

I guess you enable pinyin search. Currently if that is enabled, pinyin search will override Chinese search

@photkey
Copy link
Author

photkey commented Jan 25, 2022

I just wanted to give feedback, and sure enough, it doesn't seem to make sense.

@taooceros
Copy link
Member

I just wanted to give feedback, and sure enough, it doesn't seem to make sense.

Yeah I agree. We may recover that in next patch.

@taooceros taooceros changed the title Favorite Plugin Search for content not available Pinyin transformation does not cover query Jan 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 23, 2022
@taooceros taooceros added enhancement New feature or request and removed bug Something isn't working Stale labels May 23, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 23, 2022
@taooceros taooceros removed the Stale label Jun 23, 2022
@taooceros taooceros moved this to Todo in Work In Progress Jun 23, 2022
@taooceros taooceros added this to the 1.10.0 milestone Jun 23, 2022
@LumiaGG LumiaGG mentioned this issue Nov 15, 2022
Closed
@VictoriousRaptor VictoriousRaptor mentioned this issue Nov 16, 2022
Merged
4 tasks
@VictoriousRaptor VictoriousRaptor moved this from Todo to Ready For Review in Work In Progress Nov 17, 2022
@VictoriousRaptor VictoriousRaptor self-assigned this Nov 17, 2022
VictoriousRaptor added a commit that referenced this issue Nov 20, 2022
@VictoriousRaptor
Merge pull request #1545 from VictoriousRaptor/RefactorPinyin
3dceb7b 
Refactor pinyin alphabet and fix #995
Repository owner moved this from Ready For Review to Done in Work In Progress Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VictoriousRaptor VictoriousRaptor

Labels
enhancement New feature or request
Projects
Work In Progress
Archived in project
Milestone
1.10.0
3 participants
@VictoriousRaptor @taooceros @photkey