Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swerve #74

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Add swerve #74

wants to merge 8 commits into from

Conversation

dandeduck
Copy link
Member

Notes:
There are some things that I wasn't sure about, so I commented them, or did it in some way so you would correct it.
There is a little bit of code that still needs to be tested on a robot, but it's pretty straightforward. I will test it when I get the chance.

There are a lot of changes made to project files by vs code's Java extension.... Also, the wait a long time test fails on my machine for some reason. (unrelated to the changes)

Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't actually know much about swerve so I won't comment about the mathematics.
This should be tested though.
So I guess we will keep it waiting here until we get the chance.

.project Outdated
@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding all those files:
Place them in .gitignore (can use the root one) and then you can run:

git rm [-r] --cached {file path}

to remove them from git

}

//this is bad, but I assume there is something built in, so I will wait for the PR on this one
public static double convertAngle(double angle) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the degrees 0->360?
Mathf.translateAngle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@tomtzook tomtzook closed this Aug 31, 2021
@dandeduck dandeduck reopened this Sep 2, 2021
@dandeduck dandeduck closed this Sep 2, 2021
@dandeduck dandeduck reopened this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants