feat: Accept numbered replica database URLs #5222
Open
+48
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
for more information, see https://pre-commit.ci
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5222 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 1228 1228
Lines 42626 42644 +18
=======================================
+ Hits 41566 41584 +18
Misses 1060 1060 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5199, I tried to improve the UX for configuring replica database URLs by accepting a JSON-encoded list of database URLs. This approach is not suitable for use with Helm.
In our Helm values, there are several ways of accepting database URLs:
The problem is dealing with secret references. At deploy time, we cannot access the contents of Kubernetes secrets, so we cannot directly create a JSON-encoded list of URLs. We could imagine some workaround such as having an init container that dynamically creates this list, but this is more trouble than it's worth.
Instead, from Helm we can define each environment variable so that it gets its value from a secret. We can do this for any replica URLs that are passed in via secrets. See Flagsmith/flagsmith-charts#337 for details.
We now accept multiple environment variables such as
REPLICA_DATABASE_URL_0,REPLICA_DATABASE_URL_1, etc by starting from0and incrementing until we can't find any more variables.No docs changes for now, as this is only meant to be used by the Helm chart for now.
How did you test this code?
Unit tests.