feat: Support passing in replica URLs in JSON format #5199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
for more information, see https://pre-commit.ci
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5199 +/- ##
==========================================
+ Coverage 97.50% 97.51% +0.01%
==========================================
Files 1224 1227 +3
Lines 42623 42621 -2
==========================================
+ Hits 41558 41561 +3
+ Misses 1065 1060 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
requested changes
Mar 10, 2025
api/app/settings/common.py
Outdated
| ) | ||
|
|
||
| if REPLICA_DATABASE_URLS_JSON: |
There was a problem hiding this comment.
nit: REPLICA_DATABASE_URLS_JSON is not JSON but python here.. Maybe we can change it something like:
REPLICA_DATABASE_URLS_JSON = env.str("REPLICA_DATABASE_URLS_JSON")
if REPLICA_DATABASE_URLS_JSON:
REPLICA_DATABASE_URLS= json.loads(REPLICA_DATABASE_URLS)
github-actions
bot
added
feature
github-actions
bot
added
feature
for more information, see https://pre-commit.ci
gagantrivedi
approved these changes
Mar 12, 2025
|
Thanks for the review! I'll merge this once I can generate these variables directly from Helm. |
|
I spent way too much time trying to use this from a Helm chart and decided it's not a feasible approach. I'll open a separate PR with a different method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
REPLICA_DATABASE_URLSorCROSS_REGION_REPLICA_DATABASE_URLS, users need to know if their passwords/URLs contain a comma, and setREPLICA_DATABASE_URLS_DELIMITERaccordingly. This is annoying and not always possible, especially in environments where users might not ever have access to the raw database password such as Kubernetes secrets.Instead of having users that don't know their passwords go through trial and error, we now accept the URLs as a JSON-formatted array and avoid needing to specify a delimiter. The plan is to use this new variable to make it easier to pass arbitrary replica URLs from Helm values.