Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get validator pubkey considering KMS #821

Merged
merged 7 commits into from
Dec 13, 2022
Merged

feat: Get validator pubkey considering KMS #821

merged 7 commits into from
Dec 13, 2022

Conversation

Kynea0b
Copy link
Contributor

@Kynea0b Kynea0b commented Dec 6, 2022

Description

Change to get validator pubkey considering KMS.

Problem

The show-validator CLI provides the node's Ostracon validator information, either fetched from the local private validator or a remote private validator with the key management system (KMS).
However, the LBM coupled with the Ostracon only allows the local private validator without the remote private validator support:

@Kynea0b Kynea0b marked this pull request as draft December 6, 2022 04:15
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #821 (a833aff) into main (22edb12) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   63.15%   63.16%           
=======================================
  Files         869      869           
  Lines      100422   100422           
=======================================
+ Hits        63423    63427    +4     
+ Misses      33477    33474    -3     
+ Partials     3522     3521    -1     
Impacted Files Coverage Δ
x/token/msgs.go 52.47% <0.00%> (-3.05%) ⬇️
x/collection/msgs.go 51.19% <0.00%> (+0.14%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
server/logger.go 63.15% <0.00%> (+52.63%) ⬆️

@Kynea0b Kynea0b marked this pull request as ready for review December 6, 2022 04:50
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add changelog in CHANGELOG.md.
  • Please add a unittest to check your modifications.

server/oc_cmds.go Outdated Show resolved Hide resolved
@Kynea0b
Copy link
Contributor Author

Kynea0b commented Dec 12, 2022

@zemyblue
I've fixed these below. PTAL

  • ase add changelog in CHANGELOG.md.

b8a1a9a

  • Please add a unittest to check your modifications.

858b05a

server/oc_cmds.go Outdated Show resolved Hide resolved
server/oc_cmds.go Outdated Show resolved Hide resolved
…st to server to use a private function for testing
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b Kynea0b merged commit 04d8d91 into Finschia:main Dec 13, 2022
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Jan 12, 2023
* main: (30 commits)
  chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860)
  chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854)
  feat: Remove `x/wasm` module (Finschia#850)
  refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
  feat: enable querying based on mempool status (only gRPC) (Finschia#840)
  feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848)
  chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847)
  chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841)
  fix: apply foundation audit (Finschia#834)
  chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831)
  chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839)
  ci: automate release process (Finschia#829)
  chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832)
  chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830)
  chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826)
  chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822)
  chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828)
  feat: Get validator pubkey considering KMS (Finschia#821)
  Remove support for composite (BLS) key type (Finschia#817)
  ...

# Conflicts:
#	x/foundation/msgs.go
#	x/wasm/lbmtypes/codec.go
#	x/wasm/types/codec.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants