Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change base consensus from Ostracon to Tendermint v0.34.24 #1178

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Nov 16, 2023

Description

Change base consensus from Ostracon to Tendermint.
The base codebase of Ostracon v1.1.2 is tendermint v0.34.24.
So I convert to tendermint v0.34.24.

Changes

We already fixed #821 and cosmos-sdk also need to fix it.

related: #1177

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1178 (cf41328) into main (bfa589d) will increase coverage by 0.03%.
The diff coverage is 75.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
+ Coverage   69.71%   69.74%   +0.03%     
==========================================
  Files         646      643       -3     
  Lines       67637    67263     -374     
==========================================
- Hits        47152    46914     -238     
+ Misses      18284    18176     -108     
+ Partials     2201     2173      -28     
Files Coverage Δ
baseapp/options.go 66.94% <ø> (+0.01%) ⬆️
client/broadcast.go 53.19% <100.00%> (ø)
client/cmd.go 58.95% <ø> (ø)
client/context.go 53.93% <ø> (ø)
client/flags/flags.go 89.47% <100.00%> (ø)
client/grpc/tmservice/block.go 63.63% <100.00%> (ø)
client/grpc/tmservice/status.go 50.00% <ø> (ø)
client/keys/add.go 70.00% <100.00%> (ø)
client/keys/parse.go 77.01% <ø> (ø)
client/keys/root.go 100.00% <ø> (ø)
... and 109 more

@zemyblue zemyblue changed the title change base consensus from Ostracon to CometBFT change base consensus from Ostracon to Tendermint v0.34.24 Nov 16, 2023
@zemyblue zemyblue self-assigned this Nov 16, 2023
@zemyblue zemyblue marked this pull request as ready for review November 16, 2023 12:34
@zemyblue zemyblue added release and removed release labels Nov 16, 2023
@ulbqb
Copy link
Member

ulbqb commented Nov 17, 2023

What is the codebase version?

@zemyblue
Copy link
Member Author

What is the codebase version?

The codebase of Ostracon v1.1.2 is Tendermint v0.34.24.
So I did convert to Tendermint v0.34.24.

ulbqb
ulbqb previously approved these changes Nov 20, 2023
client/query.go Outdated Show resolved Hide resolved
client/query.go Outdated Show resolved Hide resolved
client/query.go Outdated Show resolved Hide resolved
client/query.go Outdated Show resolved Hide resolved
@ulbqb ulbqb self-requested a review November 20, 2023 09:08
@ulbqb
Copy link
Member

ulbqb commented Nov 21, 2023

The word ostracon looks to be left in .golangci.yml, Makefile.
The words ocNode, ocPk, ocProtoPk, ostPrivKey, ostPubKey, ostos, and ostcrypto/etc looks to be left in go files.

Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulbqb ulbqb self-requested a review November 21, 2023 06:16
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit e5fdd7a into Finschia:main Nov 22, 2023
40 checks passed
@zemyblue zemyblue deleted the feat/changeto_cometbft branch November 22, 2023 07:16
@zemyblue zemyblue added A: feature New features A: Client Breaking Breaking Protobuf, gRPC and REST routes used by end-users. labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Client Breaking Breaking Protobuf, gRPC and REST routes used by end-users. A: feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants