Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose used code for documenting #7

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

kfangw
Copy link
Contributor

@kfangw kfangw commented May 13, 2020

closes https://github.com/line/link/issues/799

Description

Expose usedCodes, which is registered error codes, to easy documenting

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfangw kfangw merged commit 84fc7a6 into develop May 14, 2020
@kfangw kfangw deleted the chore/usedcodes branch May 14, 2020 09:39
kfangw added a commit that referenced this pull request Sep 24, 2020
kfangw added a commit that referenced this pull request Oct 28, 2020
kfangw added a commit that referenced this pull request Nov 17, 2020
wetcod pushed a commit that referenced this pull request Dec 8, 2020
egonspace pushed a commit that referenced this pull request Mar 22, 2021
@egonspace egonspace mentioned this pull request Mar 22, 2021
9 tasks
egonspace pushed a commit that referenced this pull request Mar 23, 2021
* feat: add codespace to broadcast response (#6)

* chore: expose usedCodes for document (#7)

* fix: query error (#9)

* fix: check internalABCICodespace  (#10)

* fix: check UndefinedCodespace too

* Update types/errors/abci.go

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>

* fix: Send response with 404 status when quering non-exist account (#14)

* chore: enable github action ci

* chore: remove github access token from Dockerfile

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>
Co-authored-by: Marshall Kim <kfangw@gmail.com>
Co-authored-by: wonkuk_seo <bhb07@naver.com>
egonspace pushed a commit that referenced this pull request Mar 28, 2021
feat: golangci configuration
fiix: golangci-lint for master branch

closes issue #7
egonspace pushed a commit that referenced this pull request Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants