Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add codespace to broadcast response #6

Merged
merged 1 commit into from
May 14, 2020

Conversation

whylee259
Copy link
Contributor

@whylee259 whylee259 commented May 12, 2020

closes https://github.com/line/link/issues/390

Description

Adds codespace to responses of broadcast SYNC and ASYNC.

  • add codespace in case of mempool errors
  • set codespace from the ABCI ResultBroadcastTx

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@whylee259 whylee259 self-assigned this May 12, 2020
@whylee259
Copy link
Contributor Author

+-------------------------------------------+------------------+------------------+
|                                           |      success     |      failure     |
|                   method                  +------+-----------+------+-----------+
|                                           | code | codespace | code | codespace |
+-------------------------------------------+------+-----------+------+-----------+
| GET /txs/{hash}                           |   X  |     X     |   O  |     O     |
+-------------------------------------------+------+-----------+------+-----------+
| GET /txs                                  |   X  |     X     |   O  |     O     |
+-------------------------------------------+------+-----------+------+-----------+
| POST /txs (ASYNC)                         |   X  |     X     |   O  |     O     |
+-------------------------------------------+------+-----------+------+-----------+
| POST /txs (SYNC)                          |   X  |     X     |   O  |     O     |
+-------------------------------------------+------+-----------+------+-----------+
| POST /txs (BLOCK)                         |   X  |     X     |   O  |     O     |
+-------------------------------------------+------+-----------+------+-----------+
| GET /blocks_with_tx_results/{from_height} |   X  |     X     |   O  |     O     |
+-------------------------------------------+------+-----------+------+-----------+

@whylee259 whylee259 merged commit c4a62a7 into develop May 14, 2020
@whylee259 whylee259 deleted the feat/add-codespace-to-broadcast-response branch July 9, 2020 07:50
kfangw pushed a commit that referenced this pull request Sep 24, 2020
kfangw pushed a commit that referenced this pull request Oct 28, 2020
kfangw pushed a commit that referenced this pull request Nov 17, 2020
wetcod pushed a commit that referenced this pull request Dec 8, 2020
egonspace pushed a commit that referenced this pull request Mar 22, 2021
@egonspace egonspace mentioned this pull request Mar 22, 2021
9 tasks
egonspace pushed a commit that referenced this pull request Mar 23, 2021
* feat: add codespace to broadcast response (#6)

* chore: expose usedCodes for document (#7)

* fix: query error (#9)

* fix: check internalABCICodespace  (#10)

* fix: check UndefinedCodespace too

* Update types/errors/abci.go

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>

* fix: Send response with 404 status when quering non-exist account (#14)

* chore: enable github action ci

* chore: remove github access token from Dockerfile

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>
Co-authored-by: Marshall Kim <kfangw@gmail.com>
Co-authored-by: wonkuk_seo <bhb07@naver.com>
egonspace pushed a commit that referenced this pull request Mar 28, 2021
closes #6

Add workflows
localnet ci enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants