Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llms and chat tests failing, rework llms accordingly to new Watsonx #31

Merged
merged 55 commits into from
Nov 27, 2024

Conversation

FilipZmijewski
Copy link
Owner

@FilipZmijewski FilipZmijewski commented Nov 13, 2024

Fixes:

  • Fix chat and alms texts failing due to misleading token count
  • Fix tool_choice and add function to parse it correctly

Base automatically changed from main_ibm-community to main November 26, 2024 10:19
FilipZmijewski and others added 28 commits November 27, 2024 15:10
Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
…ts (langchain-ai#7199)

Co-authored-by: Harris <harris.chong@applydigital.com>
Co-authored-by: Ashtian <ashtian.delacruz@mail.utoronto.ca>
Co-authored-by: BaNg-W <bang344251871@gmail.com>
Co-authored-by: CarterMorris <CarterMorris@users.noreply.github.com>
Co-authored-by: BaNg-W <BaNg-W@users.noreply.github.com>
Co-authored-by: BaNg-W <114012080+BaNg-W@users.noreply.github.com>
Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
crisjy and others added 24 commits November 27, 2024 15:11
Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
…entation (langchain-ai#7200)

Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
* Fixed missing tool_choice in call options of chat (#30)

* Add rerank implementation to existing IBM community implementation (#25)

Extend existing implementation

- rename variables to camelCase
- remove default values for model
- Update and remove some tests
- update urls in documentation, shrink outputs

* Add fixes according to review (#32)

* Add fixes according to review
* Upload config info

* Fix notebooks

* Fix notebook

* Add to sidebar

* Show in docs

* Fix doc

---------

Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
@FilipZmijewski FilipZmijewski merged commit c38b7c4 into main Nov 27, 2024
29 checks passed
@FilipZmijewski FilipZmijewski deleted the fix/ibm_implementation branch November 27, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.