Add fixes according to review #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipZmijewski
added a commit
that referenced
this pull request
Nov 26, 2024
* Fixed missing tool_choice in call options of chat (#30) * Add rerank implementation to existing IBM community implementation (#25) Extend existing implementation - rename variables to camelCase - remove default values for model - Update and remove some tests - update urls in documentation, shrink outputs * Add fixes according to review (#32) * Add fixes according to review * Upload config info * Fix notebooks * Fix notebook * Add to sidebar * Show in docs * Fix doc --------- Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
FilipZmijewski
added a commit
that referenced
this pull request
Nov 27, 2024
* Fixed missing tool_choice in call options of chat (#30) * Add rerank implementation to existing IBM community implementation (#25) Extend existing implementation - rename variables to camelCase - remove default values for model - Update and remove some tests - update urls in documentation, shrink outputs * Add fixes according to review (#32) * Add fixes according to review * Upload config info * Fix notebooks * Fix notebook * Add to sidebar * Show in docs * Fix doc --------- Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes according to review from langchain