Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sparse with spzeros! in grid coloring #1064

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Replace sparse with spzeros! in grid coloring #1064

merged 1 commit into from
Sep 22, 2024

Commits on Sep 21, 2024

  1. Replace sparse with spzeros! in grid coloring 

    This patch uses the more optimal `spzeros!` instead of `sparse` when
creating the incidence matrix for the grid coloring. This doesn't
improve the performance by much, but no reason not to use it.

For a grid with 1 million elements:
  3.181 s (4537096 allocations: 1.99 GiB) # PR
  3.534 s (4537126 allocations: 2.29 GiB) # master
    @fredrikekre
    fredrikekre committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    72f9831 View commit details
    Browse the repository at this point in the history