Replace sparse with spzeros! in grid coloring
#1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch uses the more optimal `spzeros!` instead of `sparse` when creating the incidence matrix for the grid coloring. This doesn't improve the performance by much, but no reason not to use it. For a grid with 1 million elements: 3.181 s (4537096 allocations: 1.99 GiB) # PR 3.534 s (4537126 allocations: 2.29 GiB) # master
fredrikekre
force-pushed
the
fe/coloring
branch
from
228500c
to
72f9831
Compare
|
Looks like latest NearestNeighbors broke tests here @KristofferC Edit: see KristofferC/NearestNeighbors.jl#203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the more optimal
spzeros!instead ofsparsewhen creating the incidence matrix for the grid coloring. This doesn't improve the performance by much, but no reason not to use it.For a grid with 1 million elements:
3.181 s (4537096 allocations: 1.99 GiB) # PR
3.534 s (4537126 allocations: 2.29 GiB) # master