Make sure ObstructedMaze is solvable.

[SigmaBM]

Description

The blocking ball placed by the add_door may cover the box placed on the map by previous add_door, causing the agent to be unable to open certain door and unable to complete the task. To make sure this environment solvable, we can first place all the doors and their blocking balls, and then place the keys, so that it ensures that the keys will not be covered by the blocking balls added later.

Fixes # 323

Type of change

• Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

• I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pseudo-rnd-thoughts]

Could you

1. Provide a test to show the number of environments that are not solvable out of 10,000?
2. update the version numbers for all Obstructed Maze
3. Add a test to check if the environment is solvable and run 10 times in the tests.

[SigmaBM]

Could you please clarify if "update the version numbers" means changing from "v0" to "v1"? Also, which directory should I place the test files? Thank you.

[pseudo-rnd-thoughts]

Could you please clarify if "update the version numbers" means changing from "v0" to "v1"? Also, which directory should I place the test files? Thank you.

Yes, just updated the registration version number, see minigrid/__init__.py I believe and also update the documentation for the changes from v0 to v1

For testing, could you put it in tests/test_obstructed_maze.py

[SigmaBM]

I update the version number of related ObstructedMaze envs and the document. A test file is available in tests/test_obstructed_maze.py.

[pseudo-rnd-thoughts]

Could you update to explain why only some of the environments are updated

[pseudo-rnd-thoughts]

Could you add a test, test_solvable_env that the env_test for the v1 envs have a unsolvable == 0

[pseudo-rnd-thoughts]

Thanks, I think this is good.