Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update item_mapper to perform case-insensitive duplicate barcode detection for items #758

Merged

Conversation

bltravis
Copy link
Collaborator

@bltravis bltravis commented Apr 9, 2024

Closes #738

…duplicate barcodes. Fixes Use normalized version of barcode for duplicate checks #738
@bltravis bltravis linked an issue Apr 9, 2024 that may be closed by this pull request
@bltravis bltravis requested a review from banerjek April 9, 2024 06:00
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.94%. Comparing base (927072f) to head (718357a).

Files Patch % Lines
...n_tools/mapping_file_transformation/item_mapper.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   71.90%   71.94%   +0.04%     
==========================================
  Files         103      103              
  Lines       11392    11395       +3     
  Branches     1366     1366              
==========================================
+ Hits         8191     8198       +7     
+ Misses       2904     2901       -3     
+ Partials      297      296       -1     
Flag Coverage Δ
unittests 71.94% <94.11%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bltravis bltravis merged commit 64b97fd into main Apr 11, 2024
4 checks passed
@bltravis bltravis deleted the 738-use-normalized-version-of-barcode-for-duplicate-checks branch April 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use normalized version of barcode for duplicate checks
2 participants